(dsl): Support Fuzzy query #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbulaja98
requested changes
Oct 30, 2023
| * the ability to find results that are similar to, but not exactly the same as, the search term or query | ||
| * | ||
| * @param value | ||
| * the [[String]] value to represent the 'fuzziness' field |
There was a problem hiding this comment.
Suggested change
| * the [[String]] value to represent the 'fuzziness' field | |
| * the text value to represent the 'fuzziness' field |
| * @param value | ||
| * the [[String]] value to represent the 'fuzziness' field | ||
| * @return | ||
| * a new instance of the [[zio.elasticsearch.query.ElasticQuery]] with the `fuzziness` value set. |
There was a problem hiding this comment.
Suggested change
| * a new instance of the [[zio.elasticsearch.query.ElasticQuery]] with the `fuzziness` value set. | |
| * an instance of the [[zio.elasticsearch.query.ElasticQuery]] enriched with the `fuzziness` parameter. |
|
|
||
| /** | ||
| * Sets the `fuzziness` parameter for this [[zio.elasticsearch.query.ElasticQuery]]. The `fuzziness` value refers to | ||
| * the ability to find results that are similar to, but not exactly the same as, the search term or query |
There was a problem hiding this comment.
Suggested change
| * the ability to find results that are similar to, but not exactly the same as, the search term or query | |
| * the ability to find results that are similar to, but not exactly the same as, the search term or query. |
|
|
||
| /** | ||
| * Sets the `maxExpansions` parameter for this [[zio.elasticsearch.query.ElasticQuery]]. The `maxExpansions` value | ||
| * defines the maximum number of terms the fuzzy query will match before halting the search |
There was a problem hiding this comment.
Suggested change
| * defines the maximum number of terms the fuzzy query will match before halting the search | |
| * defines the maximum number of terms the fuzzy query will match before halting the search. |
| * defines the maximum number of terms the fuzzy query will match before halting the search | ||
| * | ||
| * @param value | ||
| * the whole number value for `maxExpansions` parameter |
There was a problem hiding this comment.
Suggested change
| * the whole number value for `maxExpansions` parameter | |
| * the positive whole number value for `maxExpansions` parameter |
| * refers to the number of beginning characters left unchanged when creating expansions | ||
| * | ||
| * @param value | ||
| * the whole number value for `prefixLength` parameter |
There was a problem hiding this comment.
Suggested change
| * the whole number value for `prefixLength` parameter | |
| * the positive whole number value for `prefixLength` parameter |
| * @param value | ||
| * the whole number value for `prefixLength` parameter | ||
| * @return | ||
| * a new instance of the [[zio.elasticsearch.query.ElasticQuery]] with the `prefixLength` value set. |
| @@ -1010,6 +1010,29 @@ object HttpExecutorSpec extends IntegrationSpec { | |||
| Executor.execute(ElasticRequest.createIndex(firstSearchIndex)), | |||
| Executor.execute(ElasticRequest.deleteIndex(firstSearchIndex)).orDie | |||
| ), | |||
| test("search for a document which changes a character using a fuzzy query") { | |||
There was a problem hiding this comment.
Can you rephrase this test text?
| @@ -582,6 +582,81 @@ object ElasticQuerySpec extends ZIOSpecDefault { | |||
| ) | |||
| ) | |||
| }, | |||
| test("fuzzy") { | |||
There was a problem hiding this comment.
Add one test for all parameters together.
| @@ -2189,6 +2264,79 @@ object ElasticQuerySpec extends ZIOSpecDefault { | |||
| assert(queryTs.toJson(fieldPath = None))(equalTo(expectedTs.toJson)) && | |||
| assert(queryTsWithBoost.toJson(fieldPath = None))(equalTo(expectedTsWithBoost.toJson)) | |||
| }, | |||
| test("fuzzy") { | |||
dbulaja98
requested changes
Oct 30, 2023
| title: "Fuzzy Query" | ||
| --- | ||
|
|
||
| The `Fuzzy` query returns documents that contain terms similar to the search term, as measured by a Levenshtein edit distance. |
There was a problem hiding this comment.
Add a link to this Levenshtein edit distance.
https://en.wikipedia.org/wiki/Levenshtein_distance
dbulaja98
requested changes
Oct 31, 2023
| @@ -588,7 +588,9 @@ object ElasticQuerySpec extends ZIOSpecDefault { | |||
| val queryWithCaseFuzzinessAuto = fuzzy(TestDocument.stringField, "test").fuzziness("AUTO") | |||
| @@ -588,7 +588,9 @@ object ElasticQuerySpec extends ZIOSpecDefault { | |||
| val queryWithCaseFuzzinessAuto = fuzzy(TestDocument.stringField, "test").fuzziness("AUTO") | |||
| val queryWithCaseMaxExpansions = fuzzy(TestDocument.stringField, "test").maxExpansions(50) | |||
dbulaja98
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #91