(dsl): Support refresh request
#300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbulaja98
requested changes
Aug 14, 2023
| title: "Refresh Request" | ||
| --- | ||
|
|
||
| This request refresh one or more Elasticsearch indices. |
There was a problem hiding this comment.
Maybe: This request is used for refreshing ...?
| val request: RefreshRequest = refresh(index = IndexName("index")) | ||
| ``` | ||
|
|
||
|
|
| equalTo(true) | ||
| ) | ||
| }, | ||
| test("return 'NotFound' if index does not exists") { |
There was a problem hiding this comment.
Suggested change
| test("return 'NotFound' if index does not exists") { | |
| test("return false if index does not exists") { |
| @@ -214,6 +214,17 @@ object ElasticRequest { | |||
| final def getById(index: IndexName, id: DocumentId): GetByIdRequest = | |||
| GetById(index = index, id = id, refresh = None, routing = None) | |||
|
|
|||
| /** | |||
| * Constructs an instance of [[RefreshRequest]] used for deleting an index by specified name. | |||
Comment on lines
180
to
185
| val executorRefresh = | ||
| Executor | ||
| .execute( | ||
| ElasticRequest | ||
| .refresh(name = index) | ||
| ) |
There was a problem hiding this comment.
Can this be in one line?
dbulaja98
reviewed
Aug 14, 2023
| @@ -215,7 +215,7 @@ object ElasticRequest { | |||
| GetById(index = index, id = id, refresh = None, routing = None) | |||
|
|
|||
| /** | |||
| * Constructs an instance of [[RefreshRequest]] used for deleting an index by specified name. | |||
| * Constructs an instance of [[RefreshRequest]] used for refreshing an index by specified name. | |||
There was a problem hiding this comment.
Suggested change
| * Constructs an instance of [[RefreshRequest]] used for refreshing an index by specified name. | |
| * Constructs an instance of [[RefreshRequest]] used for refreshing an index with the specified name. |
dbulaja98
requested review from
petarcurcin
and removed request for
petarcurcin
dbulaja98
approved these changes
Aug 14, 2023
dbulaja98
requested changes
Aug 15, 2023
| val request: RefreshRequest = refresh(index = IndexName("index")) | ||
| ``` | ||
|
|
||
| You can find more information about `Refresh` request [here](https://www.elastic.co/guide/en/elasticsearch/reference/7.17/indices-refresh.html). |
petarcurcin
suggested changes
Aug 15, 2023
| @@ -648,6 +658,7 @@ private[elasticsearch] object HttpExecutor { | |||
| private final val PointInTime = "_pit" | |||
| private final val Scroll = "scroll" | |||
| private final val ScrollId = "scroll_id" | |||
| private final val Refresh = "_refresh" | |||
There was a problem hiding this comment.
Put this in right order.
petarcurcin
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #262