Refactor IndexName tests #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbulaja98
requested changes
Jun 24, 2023
Comment on lines
38
to
39
| val invalidName = s"$part1*$part2" | ||
| assert(IndexName.make(invalidName))(equalTo(Validation.fail(indexNameFailureMessage(invalidName)))) |
There was a problem hiding this comment.
Can you put one empty line between?
There was a problem hiding this comment.
Do this for every test.
.bsp/sbt.json
Outdated
There was a problem hiding this comment.
Can you remove this file?
There was a problem hiding this comment.
Also .idea/misc.xml and .idea/workspace.xml.
dbulaja98
approved these changes
Jun 24, 2023
markaya
approved these changes
Jun 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #251