-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(dsl): Support source filtering in search requests #196
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8227c5d
Add HasSourceFiltering trait
mvelimir 0180f00
Implement trait for search requests
mvelimir 30454ce
Add document classes for testing
mvelimir ad501bd
Add tests
mvelimir b780b4c
Discard unused value
mvelimir 45416e3
Make trait package-private
mvelimir c1b7f18
Modify API and add Scaladoc
mvelimir cffb1ec
Replace List with Chunk
mvelimir 340ac40
Refactor expression for sourceJson
mvelimir caa6260
Fix names in pattern match
mvelimir b9932ca
Update test
mvelimir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82 changes: 82 additions & 0 deletions
82
modules/library/src/main/scala/zio/elasticsearch/request/options/HasSourceFiltering.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
/* | ||
* Copyright 2022 LambdaWorks | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package zio.elasticsearch.request.options | ||
|
||
import zio.schema.Schema | ||
|
||
private[elasticsearch] trait HasSourceFiltering[R <: HasSourceFiltering[R]] { | ||
|
||
/** | ||
* Specifies one or more fields to be excluded in the response of a [[zio.elasticsearch.ElasticRequest.SearchRequest]] | ||
* or a [[zio.elasticsearch.ElasticRequest.SearchAndAggregateRequest]]. | ||
* | ||
* @param field | ||
* a field to be excluded | ||
* @param fields | ||
* fields to be excluded | ||
* @return | ||
* an instance of a [[zio.elasticsearch.ElasticRequest.SearchRequest]] or a | ||
* [[zio.elasticsearch.ElasticRequest.SearchAndAggregateRequest]] with specified fields to be excluded. | ||
*/ | ||
def excludes(field: String, fields: String*): R | ||
|
||
/** | ||
* Specifies one or more fields to be included in the response of a [[zio.elasticsearch.ElasticRequest.SearchRequest]] | ||
* or a [[zio.elasticsearch.ElasticRequest.SearchAndAggregateRequest]]. | ||
* | ||
* @param field | ||
* a field to be included | ||
* @param fields | ||
* fields to be included | ||
* @return | ||
* an instance of a [[zio.elasticsearch.ElasticRequest.SearchRequest]] or a | ||
* [[zio.elasticsearch.ElasticRequest.SearchAndAggregateRequest]] with specified fields to be included. | ||
*/ | ||
def includes(field: String, fields: String*): R | ||
|
||
/** | ||
* Specifies fields to be included in the response of a [[zio.elasticsearch.ElasticRequest.SearchRequest]] or a | ||
* [[zio.elasticsearch.ElasticRequest.SearchAndAggregateRequest]] based on the schema of a case class. | ||
* | ||
* @tparam A | ||
* a case class whose fields will be included in the response | ||
* @param schema | ||
* a record schema of [[A]] | ||
* @return | ||
* an instance of a [[zio.elasticsearch.ElasticRequest.SearchRequest]] or a | ||
* [[zio.elasticsearch.ElasticRequest.SearchAndAggregateRequest]] with specified fields to be excluded. | ||
*/ | ||
def includes[A](implicit schema: Schema.Record[A]): R | ||
|
||
protected final def getFieldNames(schema: Schema.Record[_]): List[String] = { | ||
def extractInnerSchema(schema: Schema[_]): Schema[_] = | ||
Schema.force(schema) match { | ||
case schema: Schema.Sequence[_, _, _] => Schema.force(schema.elementSchema) | ||
case schema => schema | ||
} | ||
|
||
def loop(schema: Schema.Record[_], prefix: Option[String]): List[String] = | ||
schema.fields.toList.flatMap { field => | ||
extractInnerSchema(field.schema) match { | ||
case schema: Schema.Record[_] => loop(schema, prefix.map(_ + "." + field.name).orElse(Some(field.name))) | ||
case _ => List(prefix.fold[String](field.name)(_ + "." + field.name)) | ||
} | ||
} | ||
|
||
loop(schema, None) | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above. (Arnold's comment)