(dsl): Support 'hasChild' query #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbulaja98
reviewed
Apr 27, 2023
| * @param childType | ||
| * a name of the child relationship mapped for the join field | ||
| * @param query | ||
| * query you wish to run on child documents of the child `type` field |
Comment on lines
121
to
122
| * an instance of [[zio.elasticsearch.query.HasChildQuery]] that represents the has parent query to be performed. | ||
| */ |
Comment on lines
135
to
136
| * an instance of [[zio.elasticsearch.query.HasChildQuery]] that represents the has parent query to be performed. | ||
| */ |
| * @param childType | ||
| * a name of the child relationship mapped for the join field | ||
| * @param query | ||
| * query you wish to run on child documents of the child `type` field |
drmarjanovic
requested changes
Apr 27, 2023
| def maxChildren(value: Int): HasChildQuery[S] | ||
|
|
||
| /** | ||
| * Sets the `minChildren` parameter parameter for the [[HasChildQuery]]. |
There was a problem hiding this comment.
Suggested change
| * Sets the `minChildren` parameter parameter for the [[HasChildQuery]]. | |
| * Sets the `minChildren` parameter for the [[HasChildQuery]]. |
drmarjanovic
changed the title
drmarjanovic
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
hasChildQueryin #91Summary:
has_childqueryhas_childqueryHasParentcreation methods