Support Elastic primitive for UUID #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbulaja98
requested changes
Apr 25, 2023
Comment on lines
33
to
35
| test("successfully create matches query with Long") { | ||
| assert(matches(FieldName, 1.toLong))(equalTo(Match[Any, Long](FieldName, 1.toLong, boost = None))) | ||
| }, |
There was a problem hiding this comment.
Can you do something like 1L?
modules/library/src/test/scala/zio/elasticsearch/ElasticPrimitivesSpec.scala
Outdated
Show resolved
Hide resolved
drmarjanovic
changed the title
drmarjanovic
requested changes
Apr 25, 2023
|
|
||
| import java.util.UUID | ||
|
|
||
| object ElasticPrimitivesSpec extends ZIOSpecDefault { |
There was a problem hiding this comment.
Suggested change
| object ElasticPrimitivesSpec extends ZIOSpecDefault { | |
| object ElasticPrimitiveSpec extends ZIOSpecDefault { |
|
|
||
| object ElasticPrimitivesSpec extends ZIOSpecDefault { | ||
|
|
||
| private val fieldName = "fieldName" |
There was a problem hiding this comment.
Suggested change
| private val fieldName = "fieldName" | |
| private val FieldName = "fieldName" |
drmarjanovic
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: