-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(dsl): Support 'matchPhrase' query #172
Conversation
baa03a4
to
0a2f093
Compare
checkOnce(genDocumentId, genTestDocument, genDocumentId, genTestDocument) { | ||
(firstDocumentId, firstDocument, secondDocumentId, secondDocument) => | ||
for { | ||
_ <- Executor.execute(ElasticRequest.deleteByQuery(firstSearchIndex, matchAll)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to delete everything if we're recreating the index between each test?
import zio.Chunk | ||
import zio.json.{DeriveJsonEncoder, JsonEncoder} | ||
|
||
final case class ErrorResponse(errors: ErrorResponseData) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this result in a structure like:
{
errors: {
body: [
"This is an error"
]
}
}
?
Can we simplify that and also avoid naming a class with Data
?
Description:
Resolves
matchPhraseQuery
in #91matchPhrase
query.boost
options both formatch
andmatchPhrase
queries.paramsToJson
methods.