Introduce Newtype instead of AnyVal #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markaya
force-pushed
the
introduce-Newtype-instead-of-AnyVal
branch
3 times, most recently
from
9dd4f66 to
ec24204
Compare
drmarjanovic
requested changes
Dec 1, 2022
modules/library/src/main/scala/zio/elasticsearch/ElasticRequest.scala
Outdated
Show resolved
Hide resolved
modules/library/src/main/scala/zio/elasticsearch/HttpElasticExecutor.scala
Outdated
Show resolved
Hide resolved
drmarjanovic
requested changes
Dec 1, 2022
| "com.softwaremill.sttp.client3" %% "zio" % "3.8.3", | ||
| "com.softwaremill.sttp.client3" %% "zio-json" % "3.8.3" | ||
| "com.softwaremill.sttp.client3" %% "zio-json" % "3.8.3", | ||
| "org.apache.commons" % "commons-lang3" % "3.12.0" |
There was a problem hiding this comment.
I prefer sorting those by alphabet. So, you can order all of those that way.
modules/library/src/main/scala/zio/elasticsearch/ElasticRequest.scala
Outdated
Show resolved
Hide resolved
drmarjanovic
reviewed
Dec 1, 2022
modules/library/src/main/scala/zio/elasticsearch/ElasticRequest.scala
Outdated
Show resolved
Hide resolved
|
|
||
| package object elasticsearch { | ||
| object Routing extends Newtype[String] { | ||
| override def assertion = assert { // scalafix:ok |
There was a problem hiding this comment.
Does it make sense to use assert(!isEmptyString)?
drmarjanovic
reviewed
Dec 2, 2022
| | - Cannot be longer than 255 bytes (note it is bytes, so multi-byte characters will count towards the 255 limit faster). | ||
| | - Names starting with . are deprecated, except for hidden indices and internal indices managed by plugins. | ||
| |""".stripMargin | ||
| } |
There was a problem hiding this comment.
Does it make sense to add a new line?
| override def assertion = assertCustom { (name: String) => // scalafix:ok | ||
| if (validateIndexName(name)) Left(failure(IndexNameRequirements)) else Right(()) | ||
| } | ||
| private def validateIndexName(name: String): Boolean = |
There was a problem hiding this comment.
Does it make sense to add a new line before?
There was a problem hiding this comment.
Also, I would rename it to validate. It should be clear that is IndexName.
drmarjanovic
previously approved these changes
Dec 2, 2022
markaya
force-pushed
the
introduce-Newtype-instead-of-AnyVal
branch
from
f9a65ed to
b62728f
Compare
drmarjanovic
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.