-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap project #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll set up CI in a follow-up ticket I presume?
.gitignore
Outdated
/.idea/ | ||
/.bloop | ||
target/ | ||
/.bsp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove IDE artefacts. Developers should ignore them via their global ignore file.
LICENSE
Outdated
same "printed page" as the copyright notice for easier | ||
identification within third-party archives. | ||
|
||
Copyright 2021 John A. De Goes and the ZIO Contributors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2022, Lambdaworks. Take a look at the license template and adjust accordingly.
addCommandAlias("prepare", "fix; fmt") | ||
|
||
lazy val root = | ||
project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose putting subprojects in modules directory. I know it's not like that in zio-redis, but i believe it will improve project organization. Also, let's use root project only as an "umbrella" and aggregate all others. For example, you could have the library and the example project right now.
import Keys._ | ||
import scalafix.sbt.ScalafixPlugin.autoImport._ | ||
|
||
object BuildHelper { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll look into this one more later. It's ok for now.
) | ||
|
||
private val stdOptions = | ||
List("-deprecation", "-encoding", "UTF-8", "-feature", "-unchecked", "-Xfatal-warnings") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this -deprecation
flag work for Scala 2.13?
build.sbt
Outdated
project | ||
.in(file(".")) | ||
.aggregate(lib, example) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to disable publishing in all projects but the library.
build.sbt
Outdated
lazy val lib = | ||
project | ||
.in(file("modules/lib")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't save characters :)
Summary:
LICENSE
.gitignore
scalafix
andscalafmt
sbtx