Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap project #1

Merged
merged 14 commits into from
Aug 17, 2022
Merged

Bootstrap project #1

merged 14 commits into from
Aug 17, 2022

Conversation

drmarjanovic
Copy link
Member

Summary:

  • Provided LICENSE
  • Provided .gitignore
  • Setup both scalafix and scalafmt
  • Provided sbtx

@drmarjanovic drmarjanovic requested a review from mijicd August 16, 2022 18:33
Copy link
Collaborator

@mijicd mijicd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll set up CI in a follow-up ticket I presume?

.gitignore Outdated
Comment on lines 1 to 4
/.idea/
/.bloop
target/
/.bsp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove IDE artefacts. Developers should ignore them via their global ignore file.

LICENSE Outdated
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright 2021 John A. De Goes and the ZIO Contributors
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2022, Lambdaworks. Take a look at the license template and adjust accordingly.

addCommandAlias("prepare", "fix; fmt")

lazy val root =
project
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose putting subprojects in modules directory. I know it's not like that in zio-redis, but i believe it will improve project organization. Also, let's use root project only as an "umbrella" and aggregate all others. For example, you could have the library and the example project right now.

import Keys._
import scalafix.sbt.ScalafixPlugin.autoImport._

object BuildHelper {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look into this one more later. It's ok for now.

)

private val stdOptions =
List("-deprecation", "-encoding", "UTF-8", "-feature", "-unchecked", "-Xfatal-warnings")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this -deprecation flag work for Scala 2.13?

build.sbt Outdated
Comment on lines 23 to 25
project
.in(file("."))
.aggregate(lib, example)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to disable publishing in all projects but the library.

build.sbt Outdated
Comment on lines 27 to 29
lazy val lib =
project
.in(file("modules/lib"))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't save characters :)

@stkeky stkeky self-requested a review August 17, 2022 11:45
@stkeky stkeky merged commit 7374c91 into main Aug 17, 2022
@stkeky stkeky deleted the bootstrap-project branch August 17, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants