Improve hover popup behavior #403
Merged
+79
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrsh7th
commented
Mar 16, 2022
lambdalisue
requested changes
Mar 19, 2022
Avoid duplicated line Improve buffer/window options
hrsh7th
force-pushed
the
improve-hover-popup
branch
from
db08b81 to
6011da3
Compare
|
@hrsh7th Please re-request review when the PR is ready to review. |
lambdalisue
approved these changes
Mar 28, 2022
|
|
||
| function! s:debounced_show() abort | ||
| call s:hide() | ||
| let s:show_timer = timer_start(g:fern#drawer_hover_popup_delay, { -> s:show(fern#helper#new()) }) |
There was a problem hiding this comment.
NOTE:
Initialization of the helper instance will be changed in the next commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve the hover popup feature.
in neovim
Kapture.2022-03-16.at.16.13.40.mp4
in vim
Kapture.2022-03-16.at.16.18.30.mp4