-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix update task #30
Fix update task #30
Conversation
- Versions only specified in *deno.jsonc*, so change target. - Version specification with `^` is not updated by *molt*, so remove it.
- `--summary` or `--report` are no longer supported in `@molt/cli`. - `molt-action` is currently at v1-rc and seems to work.
WalkthroughThe recent changes focus on optimizing the update workflow by simplifying steps and leveraging a new action, Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/update.yml (1 hunks)
- deno.jsonc (1 hunks)
Additional comments not posted (4)
.github/workflows/update.yml (2)
8-10
: Permissions setup is appropriate for the workflow's requirements.
19-21
: The use ofhasundue/molt-action@v1-rc
withdeno.jsonc
as the source is correctly implemented.deno.jsonc (2)
26-26
: The update to theupdate
task to includedeno.jsonc
as an argument is correctly implemented.
30-31
: Version specifications for@std/assert
and@std/bytes
are correctly updated to exact versions.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
==========================================
+ Coverage 74.54% 77.77% +3.23%
==========================================
Files 4 4
Lines 55 72 +17
Branches 5 5
==========================================
+ Hits 41 56 +15
- Misses 14 16 +2 ☔ View full report in Codecov by Sentry. |
^
is not updated by molt, so remove it.molt/action
--summary
or--report
are no longer supported in@molt/cli
.molt-action
is currently at v1-rc and seems to work.Summary by CodeRabbit