Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update task #30

Merged
merged 2 commits into from
May 31, 2024
Merged

Fix update task #30

merged 2 commits into from
May 31, 2024

Conversation

Milly
Copy link
Contributor

@Milly Milly commented May 29, 2024

  • Versions only specified in deno.jsonc, so change target.
  • Version specification with ^ is not updated by molt, so remove it.
  • Change update workflow to use molt/action
    • --summary or --report are no longer supported in @molt/cli.
    • molt-action is currently at v1-rc and seems to work.

Summary by CodeRabbit

  • Chores
    • Updated workflow configuration to streamline steps and improve efficiency.
    • Modified dependency version specifications for better stability.

Milly added 2 commits May 29, 2024 22:44
- Versions only specified in *deno.jsonc*, so change target.
- Version specification with `^` is not updated by *molt*, so remove it.
- `--summary` or `--report` are no longer supported in `@molt/cli`.
- `molt-action` is currently at v1-rc and seems to work.
Copy link

coderabbitai bot commented May 29, 2024

Walkthrough

The recent changes focus on optimizing the update workflow by simplifying steps and leveraging a new action, hasundue/molt-action@v1-rc. Additionally, the deno.jsonc file has been updated to modify the update script and refine version specifications for dependencies.

Changes

Files Change Summary
.github/.../update.yml Reorganized workflow steps, removed setup and configuration steps, added hasundue/molt-action@v1-rc
deno.jsonc Updated update script to include deno.jsonc, fixed version specifications for @std/assert and @std/bytes

Poem

In the code's quiet night, a change did arise,
Simplifying steps, a workflow more wise.
Dependencies aligned, the versions just right,
With Molt's new action, updates take flight.
The script now runs, smooth as a breeze,
A rabbit's delight, in changes like these. 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 7d9d89c and 8990094.
Files selected for processing (2)
  • .github/workflows/update.yml (1 hunks)
  • deno.jsonc (1 hunks)
Additional comments not posted (4)
.github/workflows/update.yml (2)

8-10: Permissions setup is appropriate for the workflow's requirements.


19-21: The use of hasundue/molt-action@v1-rc with deno.jsonc as the source is correctly implemented.

deno.jsonc (2)

26-26: The update to the update task to include deno.jsonc as an argument is correctly implemented.


30-31: Version specifications for @std/assert and @std/bytes are correctly updated to exact versions.

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.77%. Comparing base (7d9d89c) to head (8990094).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   74.54%   77.77%   +3.23%     
==========================================
  Files           4        4              
  Lines          55       72      +17     
  Branches        5        5              
==========================================
+ Hits           41       56      +15     
- Misses         14       16       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lambdalisue lambdalisue merged commit f2b59b9 into lambdalisue:main May 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants