forked from matter-labs/zksync-era
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove formats #293
Merged
Merged
Remove formats #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Details:
|
juan518munoz
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
juan518munoz
merged commit Oct 8, 2024
5bea05d
into
da-eigen-implementation-m0
9 of 25 checks passed
gianbelinche
added a commit
that referenced
this pull request
Oct 9, 2024
* update contracts submodule * remove eigen proxy from general setup, add it to doc steps * Remove formats (#293) * Remove unneeded formatting * Add script explanations * Remove observability changes * remove arguments from ecosystem init * Update queries (#294) * Update contracts * Format * Update contracts * feat(vm): EVM emulator support – base (matter-labs#2979) ## What ❔ Modifies the Era codebase to support the EVM emulator. Intentionally avoids changing the `contracts` submodule yet; as a consequence, there are no EVM emulation tests. ## Why ❔ Stepping stone for EVM equivalence. ## Checklist - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`. --------- Co-authored-by: IAvecilla <[email protected]> Co-authored-by: Javier Chatruc <[email protected]> * Add dashboard step * Update queries * Format code * query changes * Remove formatting and configs * Update contracts * add max blob size to doc * Update eigenda-integration.md --------- Co-authored-by: Juan Munoz <[email protected]> Co-authored-by: Alex Ostrovski <[email protected]> Co-authored-by: IAvecilla <[email protected]> Co-authored-by: Javier Chatruc <[email protected]> Co-authored-by: juan518munoz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Remove formats. add explanation to scripts and remove observability changes
Why ❔
Checklist
zk_supervisor fmt
andzk_supervisor lint
.