This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Add bounds for out of range check in get_block_hash syscall #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoletta
reviewed
Dec 4, 2023
| self.handle_syscall_request(gas, "get_block_hash")?; | ||
|
|
||
| let current_block_number = dbg!(self.block_context.block_info.block_number); | ||
| if block_number > current_block_number - 10 { |
There was a problem hiding this comment.
This operation can panick, lets check that current_block_number is >= 10
There was a problem hiding this comment.
Or you can do this instead:
Suggested change
| if block_number > current_block_number - 10 { | |
| if block_number > current_block_number.saturating_sub(10) { |
There was a problem hiding this comment.
Or compare with an addition instead:
Suggested change
| if block_number > current_block_number - 10 { | |
| if block_number + 10 > current_block_number { |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1167 +/- ##
==========================================
- Coverage 89.61% 89.47% -0.15%
==========================================
Files 50 50
Lines 14370 14369 -1
==========================================
- Hits 12878 12856 -22
- Misses 1492 1513 +21
|
toni-calvin
force-pushed
the
fix-get-block-hash-bounds
branch
from
48bf482 to
8f91882
Compare
Oppen
approved these changes
Dec 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TITLE
Description
This PR fixes #1166
Description of the pull request changes and motivation.
Checklist