Integrate KZG prover with verifier circuit #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gabrielbosio
commented
Nov 1, 2023
•
gabrielbosio
commented
- Makes verifier circuit use foreign fields instead of native fields
- Implements temporary foreign EC operations in o1js
- Simplifies verifier circuit
- Makes verifier circuit write gates array so that KZG prover can read it and generate the corresponding proof
- Implements KZG prover
- Adds KZG prover in integration test
- Renames SRS test so that it's not considered as a testing fixture
- The failing tests cover logic that is not integrated in the circuit. We are prioritizing integration over making these tests pass.
gabrielbosio
force-pushed
the
integrate_prover
branch
from
8112d3c to
fbf86e5
Compare
gabrielbosio
force-pushed
the
integrate_prover
branch
from
0d5d015 to
be646cd
Compare
We should remove the SRS usage because it takes too long. Foreign group addition works, but scaling doesn't. See logs before keypair generation to check that.
These tests will be fixed when they use ForeignGroup instead of Group. For now, we are prioritizing integration.
gabrielbosio
changed the title
pablodeymo
reviewed
Nov 9, 2023
Co-authored-by: Pablo Deymonnaz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.