Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GET_POINT_FROM_X hint #298

Merged
merged 12 commits into from
Oct 5, 2023
Merged

Implement GET_POINT_FROM_X hint #298

merged 12 commits into from
Oct 5, 2023

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Sep 27, 2023

Closes #202

@fmoletta fmoletta marked this pull request as ready for review September 27, 2023 15:15
@fmoletta fmoletta changed the base branch from signature-hints-3 to secp-hints October 2, 2023 19:16
@pefontana pefontana merged commit e109087 into secp-hints Oct 5, 2023
@pefontana pefontana deleted the signature-hints-4 branch October 5, 2023 20:30
github-merge-queue bot pushed a commit that referenced this pull request Oct 25, 2023
* Add ec hints

* Implement hints

* Add the hints to the processor

* Test pack86 function

* Test hint

* Delete debug info, Test ec negative op

* Second hint test

* Test embedded hint

* Change to Camel case

* Implement slope hints

* Fix format

* Delete github conflict string

* Tests hints

* Tests hints slopes

* Rename misleading name function

* Fix function name

* Fix error in function call

* Delete debug info

* Delete unused import

* Secp hints

* Secpr21

* Add it to the hint processor

* Hints secp

* bigint3 nondet

* Zero verify

* Merge main

* Add hint to hint processor

* Debug info

* Prints

* Test verify with unit test

* Debug unit test

* Test verify zero with debug

* Non det big 3 test

* Modify test to use ids manager

* Add hint codes

* Implement base hint

* Add hints

* Add hints to ExecuteHint

* debug info

* Fix broken test

* Move integration test to cairo_run_test.go

* Move file from hints_utils and rename

* Delete debug

* Return error of IdsData.Insert

* Change to camel case

* Add unit test

* Add unit test

* Add hint codes

* Implement hint

* Add SafeDivBig

* Add generic way to fetch scope variables

* Add generic fetch

* Add generic way to fetch scope variables

* Use more specific error

* Add hints to ExecuteHint

* Add extra hint

* Fix logic, add unit test

* Add unit test

* use boolean flag instead or arg

* Fix scope var name

* Fix scope var name in tests

* Make FetchScopeVar work despite references

* Revert "Make FetchScopeVar work despite references"

This reverts commit 69993be.

* Handle scope variables as big.Int instead of *big.Int

* Fix merge cnflicts

* Fix tests

* Implement Igcdex + add tests

* Implement DivMod

* Use DivMod instead of Div + Mod

* Dont modify the original value in bigint3_split function

* Push test file

* Remove redundant check

* Implement Reduce_V1 hint

* Fix file names

* Add unit test

* Add testing util CheckScopeVar`

* Refactor test

* Merge math_utils/utils & utils/math_utils

* Restore gitignore

* Add hint + tests

* Add test file

* Add REDUCE_V2 hint

* Implement verify_zero hints

* Add verify_zero hints

* Fix fmt

* Implement `GET_POINT_FROM_X` hint (#298)

* Add hint code

* Implement hint

* Add unit test

* Fix test value

* Fix hint logic

* Add unit test

* Add integration test

* fmt

* Fix

* Bump cairo-vm version

---------

Co-authored-by: Milton <[email protected]>
Co-authored-by: mmsc2 <[email protected]>
Co-authored-by: Mariano A. Nicolini <[email protected]>
Co-authored-by: Pedro Fontana <[email protected]>
Co-authored-by: toni-calvin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants