feat: Implement hints on uint384 lib (Part 2) #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoletta
requested review from
igaray,
Oppen,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
Codecov Report
@@ Coverage Diff @@
## main #971 +/- ##
=======================================
Coverage 97.75% 97.75%
=======================================
Files 75 75
Lines 30970 31035 +65
=======================================
+ Hits 30274 30339 +65
Misses 696 696
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fmoletta
added
the
whitelisted-hint
Oppen
reviewed
Apr 13, 2023
Co-authored-by: Mario Rugiero <[email protected]>
Oppen
approved these changes
Apr 13, 2023
pefontana
approved these changes
Apr 13, 2023
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
* Add hint code for UINT348_UNSIGNED_DIV_REM * Add file for uint348 files * Add pack & split for uint348 * Move comment * Implement uint348_unsigned_div_rem hint * Add integration test * Add integration test * Add unit tests * Add hint on split_128 * Test split_128 hint * Add add_no_uint384_hint * Fix hint + add tests * Add hint code for UINT348_UNSIGNED_DIV_REM_EXPAND * Msc fixes * Add integration test * Reduce Uint384_expand representation to the 3 used limbs * Add unit test * Add hint code for UINT384_SQRT * Add implementation for hint on sqrt * Integration test * Add unit tests * Fix missing directive * Run cairo-format * Add hint code for UINT384_SIGNED_NN hint * Implement hint uint348_signed_nn * Add integration test * Add unit tests * Fix unit tests * Update src/hint_processor/builtin_hint_processor/uint384.rs Co-authored-by: Mario Rugiero <[email protected]> * Add changelog entry * Spelling * Add changelog entry * Fix commited suggestion * Fix test names + remove assert_matches --------- Co-authored-by: Mario Rugiero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #960
lib where these hints come from can be found here (https://github.com/NethermindEth/research-basic-Cairo-operations-big-integers/blob/main/lib/uint384.cairo)
Adds the hint: UINT384_SIGNED_NN
Checklist