Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify tests #954

Merged
merged 3 commits into from
Apr 10, 2023
Merged

Simplify tests #954

merged 3 commits into from
Apr 10, 2023

Conversation

Oppen
Copy link
Contributor

@Oppen Oppen commented Apr 10, 2023

Refactor tests in terms of small parameterized test functions. This should reduce splash damage in tests when changing interfaces.

Copy link
Collaborator

@igaray igaray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #954 (a6f4c5b) into main (725c17e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #954   +/-   ##
=======================================
  Coverage   97.74%   97.74%           
=======================================
  Files          74       74           
  Lines       30333    30333           
=======================================
  Hits        29648    29648           
  Misses        685      685           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Oppen Oppen added this pull request to the merge queue Apr 10, 2023
Merged via the queue into main with commit 6504950 Apr 10, 2023
@Oppen Oppen deleted the simplify_tests branch April 10, 2023 19:55
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jun 23, 2023
* Unify cairo_run_test.rs

* Simplify integration tests

* Remove import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants