-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move memory-related errors to MemoryError
#854
Conversation
MemoryError
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #854 +/- ##
==========================================
+ Coverage 96.82% 96.84% +0.01%
==========================================
Files 69 69
Lines 28804 28784 -20
==========================================
- Hits 27889 27875 -14
+ Misses 915 909 -6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change!
MemoryError
instead ofVirtualMachineError
Depends on Simplify
Memory::get return
type toOption
#852Will probably collide with Improve error handling of ids variables #851, should be merged afterwards