Execution resource ops add subtract #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xNonCents
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono,
Jrigada,
pefontana and
Juan-M-V
as code owners
|
Hello @0xNonCents, congrats on your first contribution! 🎉 Re: documentation: I'm on the fence about whether these APIs need it. Particularly, about whether or not I find the behavior obvious enough. |
Jrigada
suggested changes
Jan 25, 2023
mmsc2
reviewed
Jan 25, 2023
There was a problem hiding this comment.
Hello @0xNonCents nice one!. The only thing i would mention is that i added filter_unused_builtins function to have it all in the same PR, besides that it looks good.
fmoletta
reviewed
Jan 27, 2023
fmoletta
reviewed
Jan 27, 2023
fmoletta
reviewed
Jan 27, 2023
fmoletta
reviewed
Jan 27, 2023
fmoletta
reviewed
Jan 27, 2023
fmoletta
approved these changes
Jan 27, 2023
Jrigada
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ExecutionResource struct ought to have same functionalities it has in the python vm. They are used in StarkNet
https://github.com/starkware-libs/cairo-lang/blob/master/src/starkware/cairo/lang/vm/cairo_pie.py#L123
#767
Added two unit tests for each added op.
I do not believe documentation needs to be updated