Create pull_request_template.md #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azteca1998
pushed a commit
that referenced
this pull request
Feb 10, 2023
* Implemnet struct ContractStorageState * Add stuct StorageReadRequest * Add stuct StorageReadResponse * Implemet SyscallHandler::storage_read * Add STORAGE_READ to execute_syscall_hint * Add unfinished unit test * Add unit test test_os_storage_read_hint_ok * Add CachedState unit tests * Add RcRefCell CarriedState.parent_state: Option<Rc<RefCell<CarriedState<T>>>> * Modify State::get_contract_class * Add get_storage test * Add deploy_contract unit test * Modify contract_hash type from vec<u8> to [u8; 32] * Modify SyscallHandler._storage_read return type to Result<Felt,..> * Add State to BusinessLogicSyscallHandler * Remove StateComplete * Remove Storage generics in InMemoryStateReader * Implement Address.to_32_bytes() * Add test * Rename BusinessLogicSyscallHandler.starknet_storage to starknet_storage_state * Check inserts in unit test Co-authored-by: Pedro Fontana <[email protected]>
Oppen
added a commit
that referenced
this pull request
Apr 24, 2023
Version from whitelist `starknet/security/whitelists/cairo_keccak.json`, differs from the current one in bounds for `_block_size`, `1000` instead of `10`.
Oppen
added a commit
that referenced
this pull request
Apr 24, 2023
Version from whitelist `starknet/security/whitelists/cairo_keccak.json`, differs from the current one in bounds for `_block_size`, `1000` instead of `10`.
Oppen
added a commit
that referenced
this pull request
Apr 24, 2023
Version from whitelist `starknet/security/whitelists/cairo_keccak.json`, differs from the current one in bounds for `_block_size`, `1000` instead of `10`.
Oppen
added a commit
that referenced
this pull request
Apr 24, 2023
Version from whitelist `starknet/security/whitelists/cairo_keccak.json`, differs from the current one in bounds for `_block_size`, `1000` instead of `10`.
Oppen
added a commit
that referenced
this pull request
Apr 24, 2023
Version from whitelist `starknet/security/whitelists/cairo_keccak.json`, differs from the current one in bounds for `_block_size`, `1000` instead of `10`.
Oppen
added a commit
that referenced
this pull request
Apr 24, 2023
Version from whitelist `starknet/security/whitelists/cairo_keccak.json`, differs from the current one in bounds for `_block_size`, `1000` instead of `10`.
Oppen
added a commit
that referenced
this pull request
Apr 24, 2023
Version from whitelist `starknet/security/whitelists/cairo_keccak.json`, differs from the current one in bounds for `_block_size`, `1000` instead of `10`.
Oppen
added a commit
that referenced
this pull request
Apr 25, 2023
Version from whitelist `starknet/security/whitelists/cairo_keccak.json`, differs from the current one in bounds for `_block_size`, `1000` instead of `10`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a PR template in the .github folder.