Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serde: add size field to Identifier #1861

Merged
merged 4 commits into from
Nov 6, 2024

Conversation

tcoratger
Copy link
Contributor

No description provided.

@pefontana
Copy link
Collaborator

@tcoratger Why do you need this?

@tcoratger
Copy link
Contributor Author

@tcoratger Why do you need this?

@pefontana because we are building a serde service to be able to exploit Cairo VM result towards rust types and for this, we need to do in rust the equivalent of this in Python (i.e. accessing the size item for struct):

https://github.com/kkrt-labs/keth/blob/5dd36473e600936d3a633e58c4b1540480c9a04d/cairo/tests/utils/serde.py#L44

@ClementWalter
Copy link

regardless of our usage in keth, it's part of the definition of a Struct in https://github.com/starkware-libs/cairo-lang/blob/master/src/starkware/cairo/lang/compiler/identifier_definition.py#L76-L103, so there is no reason not to deserialize it in rust imho

and it's true that we actually is it in python, and so need it to migrate in rust

@pefontana
Copy link
Collaborator

Sure @tcoratger @ClementWalter !
We can add this

@ClementWalter
Copy link

are the ❌ blocking for merging? looks unrelated

@pefontana
Copy link
Collaborator

are the ❌ blocking for merging? looks unrelated

nono, everything is fine, if the CI run OK we can merge it!

@pefontana pefontana added this pull request to the merge queue Nov 6, 2024
Merged via the queue into lambdaclass:main with commit 6025257 Nov 6, 2024
68 of 71 checks passed
ClementWalter pushed a commit to kkrt-labs/keth that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants