-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Add boolean method Cairo1RunConfig::copy_to_output
+ Update Doc
#1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoletta
changed the title
refactor Add boolean method
refactor: Add boolean method May 29, 2024
Cairo1RunConfig::copy_to_output
Cairo1RunConfig::copy_to_output
fmoletta
changed the title
refactor: Add boolean method
refactor: Add boolean method May 29, 2024
Cairo1RunConfig::copy_to_output
Cairo1RunConfig::copy_to_output
+ Update Doc
fmoletta
requested review from
igaray,
Oppen,
juanbono and
pefontana
as code owners
May 29, 2024 20:17
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1778 +/- ##
=======================================
Coverage 94.78% 94.78%
=======================================
Files 101 101
Lines 39005 39014 +9
=======================================
+ Hits 36969 36978 +9
Misses 2036 2036 ☔ View full report in Codecov by Sentry. |
Benchmark Results for unmodified programs 🚀
|
Oppen
approved these changes
May 29, 2024
juanbono
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces instances of
cairo_run_config.proof_mode || cairo_run_config.append_return_values
withcairo_run_config.copy_to_output()
Updates Documentation to reflect previous changes