-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cairo1] Use a cheatcode to relocate all dicts + Make temporary segment usage configurable #1776
Merged
pefontana
merged 14 commits into
main
from
hint-processor-segment-arena-validations-flag
May 30, 2024
Merged
[Cairo1] Use a cheatcode to relocate all dicts + Make temporary segment usage configurable #1776
pefontana
merged 14 commits into
main
from
hint-processor-segment-arena-validations-flag
May 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoletta
changed the title
Only use temporary segments if sa validations are enabled + use a cheatcode to relocate all dicts by the end of the progarm
Use temporary segments for dicts based on flag + Use a cheatcode to relocate all dicts by the end of the progarm
May 27, 2024
fmoletta
changed the title
Use temporary segments for dicts based on flag + Use a cheatcode to relocate all dicts by the end of the progarm
Use temporary segments for dicts based on flag + relocate them using a cheatecode
May 27, 2024
fmoletta
changed the title
Use temporary segments for dicts based on flag + relocate them using a cheatecode
Use a cheatcode to relocate all dicts + Make temporary segment usage configurable
May 27, 2024
fmoletta
changed the title
Use a cheatcode to relocate all dicts + Make temporary segment usage configurable
[Cairo1]Use a cheatcode to relocate all dicts + Make temporary segment usage configurable
May 27, 2024
|
fmoletta
requested review from
igaray,
Oppen,
juanbono and
pefontana
as code owners
May 27, 2024 21:06
fmoletta
changed the title
[Cairo1]Use a cheatcode to relocate all dicts + Make temporary segment usage configurable
[Cairo1] Use a cheatcode to relocate all dicts + Make temporary segment usage configurable
May 27, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1776 +/- ##
==========================================
- Coverage 94.78% 94.77% -0.01%
==========================================
Files 101 101
Lines 39011 39056 +45
==========================================
+ Hits 36976 37015 +39
- Misses 2035 2041 +6 ☔ View full report in Codecov by Sentry. |
Benchmark Results for unmodified programs 🚀
|
juanbono
approved these changes
May 28, 2024
pefontana
approved these changes
May 30, 2024
This was referenced May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes commits from #1767
segment_arena_validation
&use_temporary_segments
to theCairo1HintProcessor
&DictManagerExecScope
respectively. These flags will determine if real segments or temporary segments will be used when creating dictionariesDictManagerExecScope::finalize_segment
no longer performs relocation and is ignored ifuse_temporary_segments
is set to falseDictManagerExecScope::relocate_all_dictionaries
that adds relocation rules for all tracked dictionaries, relocating them one next to the other in a new segment.RelocateAllDictionaries
to theCairo1HintProcessor
, which calls the aforementioned methodcreate_entry_code
if eitherproof_mode
orappend_return_values
are set to true, and segment arena is presentTLDR: