Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cairo1-run CLI: Set finalize_builtins to true when using --air_public_input flag #1752

Merged
merged 3 commits into from
May 8, 2024
Merged

cairo1-run CLI: Set finalize_builtins to true when using --air_public_input flag #1752

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99fb010
cairo1-run CLI: Set `finalize_builtins` to true when using `--air_pub…
fmoletta May 7, 2024
c1f7acc
Update CHANGELOG.md
fmoletta May 7, 2024
3614442
Fix typo
fmoletta May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

#### Upcoming Changes

* bugifx: cairo1-run CLI: Set finalize_builtins to true when using --air_public_input flag [#1744](https://github.com/lambdaclass/cairo-vm/pull/1752)
fmoletta marked this conversation as resolved.
Show resolved Hide resolved

* feat: Add hint `U256InvModN` to `Cairo1HintProcessor` [#1744](https://github.com/lambdaclass/cairo-vm/pull/1744)

* perf: use a more compact representation for `MemoryCell` [#1672](https://github.com/lambdaclass/cairo-vm/pull/1672)
Expand Down
2 changes: 1 addition & 1 deletion cairo1-run/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ fn run(args: impl Iterator<Item = String>) -> Result<Option<String>, Error> {
layout: args.layout,
trace_enabled: args.trace_file.is_some() || args.air_public_input.is_some(),
args: &args.args.0,
finalize_builtins: args.air_private_input.is_some() || args.cairo_pie_output.is_some(),
finalize_builtins: args.air_public_input.is_some() || args.cairo_pie_output.is_some(),
append_return_values: args.append_return_values,
};

Expand Down
Loading