Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use program builtins in initialize_main_entrypoint & read_return_values #1703

Merged
merged 157 commits into from
Apr 10, 2024

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Apr 9, 2024

Fixes these two methods, and other inconsistencies in other methods.
Add tests to run programs with missing builtins

@fmoletta fmoletta marked this pull request as ready for review April 9, 2024 22:00
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 86.27451% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 94.93%. Comparing base (ca3b8ab) to head (2c8cb4d).

Files Patch % Lines
vm/src/cairo_run.rs 16.66% 5 Missing ⚠️
vm/src/vm/runners/builtin_runner/modulo.rs 0.00% 5 Missing ⚠️
vm/src/vm/runners/builtin_runner/mod.rs 85.71% 2 Missing ⚠️
vm/src/vm/runners/cairo_runner.rs 97.10% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1703      +/-   ##
==========================================
- Coverage   94.96%   94.93%   -0.04%     
==========================================
  Files          99       99              
  Lines       38532    38579      +47     
==========================================
+ Hits        36592    36625      +33     
- Misses       1940     1954      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pefontana pefontana added this pull request to the merge queue Apr 10, 2024
@pefontana pefontana removed this pull request from the merge queue due to the queue being cleared Apr 10, 2024
@pefontana pefontana added this pull request to the merge queue Apr 10, 2024
@pefontana pefontana removed this pull request from the merge queue due to a manual request Apr 10, 2024
@pefontana pefontana added this pull request to the merge queue Apr 10, 2024
@pefontana pefontana removed this pull request from the merge queue due to a manual request Apr 10, 2024
@pefontana pefontana added this pull request to the merge queue Apr 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 10, 2024
@pefontana pefontana added this pull request to the merge queue Apr 10, 2024
Merged via the queue into main with commit 6de8f56 Apr 10, 2024
69 of 70 checks passed
@pefontana pefontana deleted the fix-read-return-values branch April 10, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants