Feature: compute program hash chain #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odesenfans
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono and
pefontana
as code owners
odesenfans
force-pushed
the
msl/program-hash-chain
branch
from
3305ccf to
9cac9db
Compare
|
Some more backporting from the bootloader hints. This new module allows to get the hash of a program to replace the functionality of the |
fmoletta
reviewed
Mar 5, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1647 +/- ##
==========================================
+ Coverage 96.70% 96.71% +0.01%
==========================================
Files 95 96 +1
Lines 38154 38246 +92
==========================================
+ Hits 36897 36990 +93
+ Misses 1257 1256 -1 ☔ View full report in Codecov by Sentry. |
odesenfans
force-pushed
the
msl/program-hash-chain
branch
from
cdb2b59 to
1684d17
Compare
fmoletta
approved these changes
Mar 8, 2024
Problem: computing the hash of a program is useful to verify its integrity. This hash is also used for different purposes, like when loading a program with the bootloader. Solution: add a `program_hash` module and the `compute_program_hash_chain` function that computes the hash of a stripped program, making it usable with `Program` and `CairoPie` objects.
odesenfans
force-pushed
the
msl/program-hash-chain
branch
from
1684d17 to
09e4be2
Compare
juanbono
approved these changes
Apr 5, 2024
juanbono
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: computing the hash of a program is useful to verify its integrity. This hash is also used for different purposes, like when loading a program with the bootloader.
Solution: add a
program_hashmodule and thecompute_program_hash_chainfunction that computes the hash of a stripped program, making it usable withProgramandCairoPieobjects.Description of the pull request changes and motivation.
Checklist