Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tracer pr #1643

Merged
merged 8 commits into from
Mar 8, 2024
Merged

New tracer pr #1643

merged 8 commits into from
Mar 8, 2024

Conversation

apoorvsadana
Copy link
Contributor

Description

  • Track the ap, fp, pc and the state of the memory in each step of the execution.
  • A new crate cairo-vm-tracer which starts a server on the localhost where you can see an web UI. The UI allows you to interact with your Cairo programs and see what's happening inside the VM.
  • Most functionality in existing crates has been put behind feature flags with_tracer and tracer

CHANGELOG.md Outdated Show resolved Hide resolved
docs/tracer/README.md Outdated Show resolved Hide resolved
cairo-vm-cli/src/main.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 19.69697% with 265 lines in your changes are missing coverage. Please review.

Project coverage is 96.70%. Comparing base (6ae7b32) to head (bbde843).

Files Patch % Lines
cairo-vm-tracer/src/tracer_data.rs 0.00% 154 Missing ⚠️
cairo-vm-tracer/src/tracer.rs 0.00% 91 Missing ⚠️
vm/src/serde/deserialize_program.rs 0.00% 15 Missing ⚠️
vm/src/vm/context/run_context.rs 0.00% 3 Missing ⚠️
cairo-vm-tracer/src/error/trace_data_errors.rs 0.00% 1 Missing ⚠️
cairo-vm-tracer/src/types/memory_access.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1643      +/-   ##
==========================================
- Coverage   97.66%   96.70%   -0.97%     
==========================================
  Files          91       95       +4     
  Lines       37712    38154     +442     
==========================================
+ Hits        36833    36897      +64     
- Misses        879     1257     +378     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@pefontana pefontana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amaizing @apoorvsadana !!!!
I try it and works perfect!
Just some points:

  • Run the make clippy command that is failing in the CI
  • Is necessary to push the .idea folder, if you cant, can we move it inside cairo-vm-tracer/

Copy link
Collaborator

@pefontana pefontana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICEEEEEEE!

Copy link
Contributor

@fmoletta fmoletta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pefontana pefontana added this pull request to the merge queue Mar 8, 2024
Merged via the queue into lambdaclass:main with commit 105ca3a Mar 8, 2024
50 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants