-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New tracer pr #1643
New tracer pr #1643
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1643 +/- ##
==========================================
- Coverage 97.66% 96.70% -0.97%
==========================================
Files 91 95 +4
Lines 37712 38154 +442
==========================================
+ Hits 36833 36897 +64
- Misses 879 1257 +378 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amaizing @apoorvsadana !!!!
I try it and works perfect!
Just some points:
- Run the make clippy command that is failing in the CI
- Is necessary to push the .idea folder, if you cant, can we move it inside cairo-vm-tracer/
Co-authored-by: fmoletta <[email protected]>
Co-authored-by: fmoletta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NICEEEEEEE!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Description