Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cairo_pie_output flag to cairo1-run #1581

Merged
merged 46 commits into from
Jan 22, 2024
Merged

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Jan 18, 2024

No description provided.

@fmoletta fmoletta changed the base branch from main to cairo_pie_output January 18, 2024 17:22
@fmoletta fmoletta linked an issue Jan 18, 2024 that may be closed by this pull request
@fmoletta fmoletta marked this pull request as ready for review January 18, 2024 17:27
Copy link

github-actions bot commented Jan 18, 2024

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.259 ± 0.010 2.245 2.272 1.01 ± 0.01
head big_factorial 2.242 ± 0.012 2.221 2.256 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.227 ± 0.015 2.205 2.252 1.00
head big_fibonacci 2.227 ± 0.009 2.213 2.240 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.139 ± 0.066 8.064 8.230 1.00 ± 0.01
head blake2s_integration_benchmark 8.133 ± 0.072 8.045 8.277 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.294 ± 0.005 2.289 2.305 1.01 ± 0.01
head compare_arrays_200000 2.271 ± 0.012 2.257 2.292 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.458 ± 0.013 1.449 1.491 1.00
head dict_integration_benchmark 1.460 ± 0.035 1.443 1.561 1.00 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.283 ± 0.008 1.274 1.298 1.00
head field_arithmetic_get_square_benchmark 1.287 ± 0.007 1.275 1.298 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.175 ± 0.062 8.092 8.294 1.00 ± 0.01
head integration_builtins 8.168 ± 0.053 8.116 8.295 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.423 ± 0.038 8.374 8.513 1.01 ± 0.01
head keccak_integration_benchmark 8.366 ± 0.035 8.331 8.424 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.326 ± 0.012 2.305 2.342 1.01 ± 0.01
head linear_search 2.305 ± 0.009 2.298 2.322 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.607 ± 0.014 1.594 1.631 1.00 ± 0.02
head math_cmp_and_pow_integration_benchmark 1.599 ± 0.029 1.587 1.682 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.450 ± 0.007 1.438 1.462 1.00
head math_integration_benchmark 1.460 ± 0.021 1.440 1.513 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.258 ± 0.005 1.250 1.266 1.00 ± 0.00
head memory_integration_benchmark 1.255 ± 0.002 1.254 1.261 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.629 ± 0.005 1.623 1.637 1.00
head operations_with_data_structures_benchmarks 1.642 ± 0.004 1.635 1.646 1.01 ± 0.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 604.4 ± 1.1 602.8 606.5 1.00 ± 0.00
head pedersen 604.0 ± 1.5 601.3 605.7 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.072 ± 0.009 1.060 1.094 1.01 ± 0.01
head poseidon_integration_benchmark 1.066 ± 0.005 1.059 1.074 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.933 ± 0.009 1.921 1.951 1.00
head secp_integration_benchmark 1.937 ± 0.008 1.930 1.954 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 753.9 ± 1.4 752.3 757.2 1.00 ± 0.00
head set_integration_benchmark 751.1 ± 1.7 748.3 753.2 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.529 ± 0.029 4.492 4.575 1.00 ± 0.01
head uint256_integration_benchmark 4.521 ± 0.019 4.502 4.566 1.00

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2f715c4) 97.06% compared to head (2a9efb4) 97.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1581      +/-   ##
==========================================
+ Coverage   97.06%   97.15%   +0.08%     
==========================================
  Files          91       91              
  Lines       37221    37194      -27     
==========================================
+ Hits        36130    36134       +4     
+ Misses       1091     1060      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

juanbono
juanbono previously approved these changes Jan 22, 2024
Base automatically changed from cairo_pie_output to main January 22, 2024 21:20
@Oppen Oppen dismissed juanbono’s stale review January 22, 2024 21:20

The base branch was changed.

Copy link
Collaborator

@pefontana pefontana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@pefontana pefontana added this pull request to the merge queue Jan 22, 2024
Merged via the queue into main with commit 826e72c Jan 22, 2024
50 checks passed
@pefontana pefontana deleted the cairo_pie_output_cairo_1 branch January 22, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a --cairo_pie_output to Cairo 1 CLI
3 participants