small fix to cancel duplicate workflow file #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greged93
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono and
pefontana
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1497 +/- ##
=======================================
Coverage 96.82% 96.82%
=======================================
Files 96 96
Lines 39684 39684
=======================================
Hits 38423 38423
Misses 1261 1261 ☔ View full report in Codecov by Sentry. |
|
I seem to recall this workaround is not even needed anymore: I believe |
|
ah true, I can just remove it then. |
|
We would need to check the |
|
so right now, this workflow was cancelling the runs for |
|
I think that would work, yes. |
Oppen
approved these changes
Nov 30, 2023
fmoletta
reviewed
Dec 4, 2023
fmoletta
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix workflow error
Description
Fixes a small issue in the cancel-duplicate workflow file. The cancellation of the bench workflow is not needed for bench_pull_request anymore since this was removed. Not sure if you want to add the hyperfine workflow to it, let me know.
Checklist