feat: add cairo_run_program function that takes a Program as an arg #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElijahVlasov
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono and
pefontana
as code owners
fmoletta
approved these changes
Nov 27, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1496 +/- ##
=======================================
Coverage 96.81% 96.81%
=======================================
Files 96 96
Lines 39574 39581 +7
=======================================
+ Hits 38315 38322 +7
Misses 1259 1259 ☔ View full report in Codecov by Sentry. |
Oppen
approved these changes
Nov 27, 2023
|
Also, clippy is complaining about taking a reference to |
ElijahVlasov
force-pushed
the
cairo-run-program
branch
from
0b9119c to
ddbf4a2
Compare
Should be fine now |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
cairo_run_programfunction tocairo_runner.Description
It seems convenient to have an API function that runs a cairo program from a
Programstruct, not a serialized JSON representation. For instance, in my use-case the program comes from a compressed binary representation, not from a json, so don't want to copy the content ofcairo_runfunction in my project for that.If this is useful for someone barring me please consider this tiny PR :)