Make AirPublicInputs fields public

[pefontana]

Make AirPublicInputs fields public

Checklist

• Linked to Github Issue
• Unit tests added
• Integration tests added.
• This change requires new documentation.
  • Documentation has been added/updated.
  • CHANGELOG has been updated.

[github-actions]

Benchmark Results for unmodified programs 🚀

Command	Mean [s]	Min [s]	Max [s]	Relative
base big_factorial	2.651 ± 0.021	2.625	2.702	1.02 ± 0.01
head big_factorial	2.607 ± 0.022	2.581	2.651	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base big_fibonacci	2.242 ± 0.032	2.205	2.316	1.02 ± 0.02
head big_fibonacci	2.197 ± 0.011	2.180	2.215	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base blake2s_integration_benchmark	6.013 ± 0.043	5.934	6.076	1.01 ± 0.01
head blake2s_integration_benchmark	5.956 ± 0.037	5.914	6.043	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base compare_arrays_200000	2.292 ± 0.020	2.265	2.328	1.02 ± 0.01
head compare_arrays_200000	2.258 ± 0.012	2.238	2.278	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base dict_integration_benchmark	1.600 ± 0.015	1.581	1.635	1.01 ± 0.01
head dict_integration_benchmark	1.581 ± 0.015	1.559	1.609	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base field_arithmetic_get_square_benchmark	1.045 ± 0.005	1.038	1.058	1.00
head field_arithmetic_get_square_benchmark	1.051 ± 0.019	1.031	1.101	1.01 ± 0.02

Command	Mean [s]	Min [s]	Max [s]	Relative
base integration_builtins	5.977 ± 0.042	5.927	6.061	1.00 ± 0.01
head integration_builtins	5.955 ± 0.038	5.908	6.026	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base keccak_integration_benchmark	6.069 ± 0.044	6.002	6.129	1.01 ± 0.01
head keccak_integration_benchmark	6.036 ± 0.044	5.962	6.094	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base linear_search	2.277 ± 0.020	2.245	2.309	1.02 ± 0.01
head linear_search	2.243 ± 0.008	2.229	2.253	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base math_cmp_and_pow_integration_benchmark	1.570 ± 0.015	1.541	1.602	1.01 ± 0.01
head math_cmp_and_pow_integration_benchmark	1.555 ± 0.008	1.543	1.567	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base math_integration_benchmark	1.496 ± 0.022	1.469	1.542	1.02 ± 0.02
head math_integration_benchmark	1.472 ± 0.006	1.464	1.485	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base memory_integration_benchmark	1.313 ± 0.013	1.297	1.336	1.01 ± 0.02
head memory_integration_benchmark	1.303 ± 0.019	1.282	1.345	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base operations_with_data_structures_benchmarks	1.462 ± 0.007	1.448	1.472	1.02 ± 0.01
head operations_with_data_structures_benchmarks	1.439 ± 0.006	1.429	1.450	1.00

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
base pedersen	583.4 ± 2.5	578.9	587.0	1.00 ± 0.01
head pedersen	582.9 ± 3.3	578.5	590.5	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base poseidon_integration_benchmark	1.168 ± 0.005	1.159	1.175	1.01 ± 0.01
head poseidon_integration_benchmark	1.162 ± 0.007	1.155	1.177	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base secp_integration_benchmark	2.037 ± 0.038	2.012	2.141	1.01 ± 0.02
head secp_integration_benchmark	2.027 ± 0.016	2.007	2.057	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base set_integration_benchmark	1.157 ± 0.007	1.146	1.167	1.00 ± 0.01
head set_integration_benchmark	1.155 ± 0.004	1.151	1.164	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base uint256_integration_benchmark	3.879 ± 0.029	3.849	3.943	1.01 ± 0.01
head uint256_integration_benchmark	3.858 ± 0.033	3.804	3.901	1.00

[entropidelic]

from the prover side, we don't really need the layout params as public, at least for the moment. With the name which appears in the layout field should be ok 👍

[pefontana]

great!
Done 509bed0

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (74fa49a) 96.82% compared to head (2dbc462) 96.82%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1474   +/-   ##
=======================================
  Coverage   96.82%   96.82%           
=======================================
  Files          95       95           
  Lines       39451    39451           
=======================================
  Hits        38199    38199           
  Misses       1252     1252           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Oppen]

Issues:
– There seems to be a version conflict for the toolchain in the IAI benchmarks
– The PR is labeled pipelines rather than having its changelog updated, we should do the latter

[pefontana]

Issues: – There seems to be a version conflict for the toolchain in the IAI benchmarks – The PR is labeled pipelines rather than having its changelog updated, we should do the latter

Yes, you are right @Oppen !
Changelog updated,
About the CI error, I re-run it and it pass ok

[Oppen]

About the CI error, I re-run it and it pass ok

It still shows as failing https://github.com/lambdaclass/cairo-vm/actions/runs/6851613543/job/18628280029?pr=1474