fix: change return error type of get_execution_resources to RunnerError #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PanGan21
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
fmoletta
reviewed
Aug 24, 2023
Codecov Report
@@ Coverage Diff @@
## main #1398 +/- ##
=======================================
Coverage 96.96% 96.96%
=======================================
Files 94 94
Lines 38645 38645
=======================================
Hits 37473 37473
Misses 1172 1172
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: fmoletta <[email protected]>
fmoletta
approved these changes
Aug 24, 2023
pefontana
approved these changes
Aug 29, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TITLE
Description
Description of the pull request changes and motivation.
Change return error type of get_execution_resources to RunnerError.
Closes #1378
Checklist