-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing call to initialize
in cairo_run_parsed_program
#1330
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ser
Codecov Report
@@ Coverage Diff @@
## main #1330 +/- ##
==========================================
+ Coverage 97.53% 97.88% +0.35%
==========================================
Files 92 89 -3
Lines 37474 35529 -1945
==========================================
- Hits 36549 34778 -1771
+ Misses 925 751 -174
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Benchmark Results for unmodified programs 🚀
|
…ambdaclass#1330) * fix: add missing `CairoRunner::initialize` call * Ignore `VirtualMachineError::EndOfProgram` error * Update changelog * Add "fuzzing" scope to changelog entry * Remove whitespace
…ambdaclass#1330) * fix: add missing `CairoRunner::initialize` call * Ignore `VirtualMachineError::EndOfProgram` error * Update changelog * Add "fuzzing" scope to changelog entry * Remove whitespace
Description
This missing call meant passing an empty program would cause a panic. Also, now it ignores the error caused by reaching the program's end with steps remaining.
Checklist