-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove unused dependencies #1307
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1307 +/- ##
=======================================
Coverage 97.90% 97.90%
=======================================
Files 89 89
Lines 35471 35471
=======================================
Hits 34727 34727
Misses 744 744 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Benchmark Results for unmodified programs 🚀
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! ❤️
Just for fun, could you check if build times/binary size change? |
Compilation time varies by a lot but didn't change much it seems. Size decreased by 8 bytes 🚀 (in debug)
|
Size go brrrrr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thougt that the .rusty-hook.toml needed the rusty-hook deps
Tried it and the cargo fmt rusty hook still works so LGTM
* Remove unused dependencies * Update changelog
* Remove unused dependencies * Update changelog
* Remove unused dependencies * Update changelog
* Remove unused dependencies * Update changelog
Description
This PR removes some unused dependencies, as reported by cargo-udeps. Those dependencies are:
Checklist