-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add check against cache overflow #1285
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
June 27, 2023 14:46
MegaRedHand
changed the title
Add check against cache overflow
fix: add check against cache overflow
Jun 27, 2023
Oppen
reviewed
Jun 27, 2023
Benchmark Results for unmodified programs 🚀
|
Oppen
approved these changes
Jun 27, 2023
Codecov Report
@@ Coverage Diff @@
## main #1285 +/- ##
=======================================
Coverage 97.90% 97.90%
=======================================
Files 89 89
Lines 35465 35469 +4
=======================================
+ Hits 34723 34727 +4
Misses 742 742
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
juanbono
approved these changes
Jun 29, 2023
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jul 4, 2023
* Add check against cache overflow * Fix off-by-one error * Update changelog
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jul 4, 2023
* Add check against cache overflow * Fix off-by-one error * Update changelog
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jul 25, 2023
* Add check against cache overflow * Fix off-by-one error * Update changelog
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jul 25, 2023
* Add check against cache overflow * Fix off-by-one error * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1283
Description
This PR adds a check before resizing the cache, to avoid a panic when jumping to a high and inexistent
pc
.Checklist