-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix to_signed_felt doc #1262
fix to_signed_felt doc #1262
Conversation
Could you add an entry to the changelog regarding this change? Something like:
|
Codecov Report
@@ Coverage Diff @@
## main #1262 +/- ##
=======================================
Coverage 97.60% 97.60%
=======================================
Files 89 89
Lines 36335 36335
=======================================
Hits 35466 35466
Misses 869 869
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@MegaRedHand |
The function won't be removed in the foreseeable future. We can merge this for now (once we update the changelog). Context: we are changing the underlying implementation of |
Will rebase and update the change log then :) |
I think the PR can be closed, doctests were fixed by #1281 :) |
Fix doc tests
Description
The current documentation for
to_signed_felt
andtake_until_unbalanced
are incorrect and caused the doc tests to fail.Checklist