-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: remove unneeded bitshift in validated addresses insertion #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark Results for unmodified programs 🚀
|
Codecov Report
@@ Coverage Diff @@
## main #1208 +/- ##
=======================================
Coverage 97.49% 97.49%
=======================================
Files 93 93
Lines 37853 37854 +1
=======================================
+ Hits 36903 36904 +1
Misses 950 950
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
MegaRedHand
changed the title
perf: remove unneeded? shift in validated addresses insertion
perf: remove unneeded bitshift in validated addresses insertion
Jun 6, 2023
MegaRedHand
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
June 6, 2023 19:12
The +1 in resize is used to avoid having to allocate in the case the next push falls outside capacity. Instead, we use a replace in the place of the insert.
Oppen
approved these changes
Jul 18, 2023
juanbono
approved these changes
Jul 31, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TITLE
Description
This PR changes the
insert
used inAddressSet::extend
for areplace
. This caused the vec to have a trailingfalse
that was later truncated and that caused theinsert
to use a bitshift on the last element (as shown in flamegraphs).Checklist