Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for hint FieldSqrt #1162

Merged
merged 114 commits into from
May 12, 2023
Merged

Add test for hint FieldSqrt #1162

merged 114 commits into from
May 12, 2023

Conversation

rcatalan98
Copy link
Contributor

@rcatalan98 rcatalan98 commented May 12, 2023 •
edited
Loading

Add test for hint FieldSqrt

Description

This PR adds a Cairo 1 program in order to test FieldSqrt hint.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

Closes #1135

fmoletta added 30 commits April 28, 2023 12:35
@fmoletta
Implement TryFrom<CasmContractClass> for Program
ad090c0
@fmoletta
Add cairo1hintprocessor dependency
814f62f
@fmoletta
Map hints to pc
5ad52b3
@fmoletta
Add Cairo1HintProcessor
2c80935
@fmoletta
Move cairo-1-hint-processor to cairo-rs crate
31833c0
@fmoletta
fixes
a0974fc
@fmoletta
Fix test helper
3257b9d
@fmoletta
Remove allow
6eb32a6
@fmoletta
fix test func
95be386
@fmoletta
Add builtins to test
0ce7380
@fmoletta
Extract builtins from contract_class
ee4db2c
@fmoletta
Add _builtin to builtin names in etrypoint data
f0d4151
@fmoletta
Copy logic from cairo1 contract execution in starknet
4032a94
@fmoletta
Remove unused code
6c9be63
@fmoletta
Use lower initial_gas value
52984d7
@fmoletta
Add program segment size argument
151375f
@fmoletta
Check return values in run_cairo_1_entrypoint fn
f11e350
@fmoletta
Remove debug prints
f466aa7
@fmoletta
Add basic fibonacci test
8a528a0
@fmoletta
Add another fibonacci case
c4fbe31
@fmoletta
Always verify secure
5debb70
@fmoletta
Clippy
4d614a8
@fmoletta
Compile casm contracts when running test target
df1bf8f
@fmoletta
Remove unwrap from cell_ref_to_relocatable
59b6381
@fmoletta
Remove paniking macro from extract_buffer
2649829
@fmoletta
Misc improvements
ecb58d6
@fmoletta
Misc improvements
2d9362d
@fmoletta
Misc improvements
38be92c
@fmoletta
Misc improvements
a82308b
@fmoletta
Remove unwraps & asserts from DictSquashExecScope::pop_current_key
8d6c5cb
@github-actions
Copy link

github-actions bot commented May 12, 2023 •
edited
Loading

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 16.376 ± 0.174 16.124 16.653 1.00
head blake2s_integration_benchmark 16.469 ± 0.449 15.951 17.264 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 5.148 ± 0.126 4.993 5.390 1.01 ± 0.03
head compare_arrays_200000 5.113 ± 0.046 5.045 5.219 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 3.299 ± 0.030 3.247 3.352 1.00
head dict_integration_benchmark 3.340 ± 0.043 3.296 3.446 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 5.587 ± 0.057 5.470 5.672 1.00 ± 0.02
head factorial_multirun 5.560 ± 0.061 5.441 5.632 1.00
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 4.602 ± 0.042 4.542 4.657 1.00 ± 0.02
head fibonacci_1000_multirun 4.592 ± 0.090 4.497 4.814 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base field_arithmetic_get_square_benchmark 221.6 ± 6.0 215.4 235.9 1.00
head field_arithmetic_get_square_benchmark 223.5 ± 3.6 218.2 231.4 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 15.391 ± 1.288 14.588 18.962 1.01 ± 0.09
head integration_builtins 15.299 ± 0.328 14.543 15.778 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 17.201 ± 0.976 16.363 19.646 1.04 ± 0.07
head keccak_integration_benchmark 16.580 ± 0.510 15.975 17.557 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 5.022 ± 0.051 4.966 5.141 1.00
head linear_search 5.047 ± 0.055 4.980 5.152 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 3.563 ± 0.037 3.522 3.636 1.01 ± 0.01
head math_cmp_and_pow_integration_benchmark 3.521 ± 0.034 3.485 3.594 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 3.258 ± 0.041 3.221 3.348 1.00
head math_integration_benchmark 3.283 ± 0.076 3.188 3.455 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.827 ± 0.060 2.741 2.959 1.00
head memory_integration_benchmark 2.922 ± 0.040 2.853 2.979 1.03 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 3.391 ± 0.063 3.292 3.518 1.04 ± 0.03
head operations_with_data_structures_benchmarks 3.270 ± 0.068 3.179 3.382 1.00
Command Mean [s] Min [s] Max [s] Relative
base pedersen 1.083 ± 0.016 1.045 1.108 1.04 ± 0.02
head pedersen 1.037 ± 0.013 1.019 1.058 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.813 ± 0.025 1.791 1.850 1.01 ± 0.02
head poseidon_integration_benchmark 1.800 ± 0.027 1.773 1.853 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 3.958 ± 0.032 3.907 4.010 1.00
head secp_integration_benchmark 4.061 ± 0.076 3.961 4.176 1.03 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 2.270 ± 0.023 2.237 2.303 1.00
head set_integration_benchmark 2.301 ± 0.040 2.246 2.350 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 9.998 ± 0.243 9.570 10.294 1.00
head uint256_integration_benchmark 10.023 ± 0.211 9.733 10.306 1.00 ± 0.03

@rcatalan98 rcatalan98 marked this pull request as ready for review May 12, 2023 18:57
fmoletta
fmoletta approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@fmoletta fmoletta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 12, 2023 •
edited
Loading

Codecov Report

Merging #1162 (600a84b) into main (ea1bfa3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1162   +/-   ##
=======================================
  Coverage   97.57%   97.57%           
=======================================
  Files          89       89           
  Lines       35632    35632           
=======================================
  Hits        34767    34767           
  Misses        865      865

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pefontana pefontana enabled auto-merge May 12, 2023 20:49
@pefontana pefontana added this pull request to the merge queue May 12, 2023
Merged via the queue into main with commit 6fc4a5c May 12, 2023
@pefontana pefontana deleted the test-hint-field_sqrt branch May 12, 2023 21:34
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jun 23, 2023
@rcatalan98 @fmoletta
@pefontana @kariy
Add test for hint FieldSqrt (lambdaclass#1162)
73b233c 
* Implement TryFrom<CasmContractClass> for Program

* Add cairo1hintprocessor dependency

* Map hints to pc

* Add Cairo1HintProcessor

* Move cairo-1-hint-processor to cairo-rs crate

* fixes

* Fix test helper

* Remove allow

* fix test func

* Add builtins to test

* Extract builtins from contract_class

* Add _builtin to builtin names in etrypoint data

* Copy logic from cairo1 contract execution in starknet

* Remove unused code

* Use lower initial_gas value

* Add program segment size argument

* Check return values in run_cairo_1_entrypoint fn

* Remove debug prints

* Add basic fibonacci test

* Add another fibonacci case

* Always verify secure

* Clippy

* Compile casm contracts when running test target

* Remove unwrap from cell_ref_to_relocatable

* Remove paniking macro from extract_buffer

* Misc improvements

* Misc improvements

* Misc improvements

* Misc improvements

* Remove unwraps & asserts from DictSquashExecScope::pop_current_key

* Remove unwraps & asserts from DictManagerExecScope::new_default_dict

* Remove expect from get_dict_tracker

* Add constants for cairo 1 compiler binaries in makefile

* Add cairo 1 compiler to deps target in makefile

* Add cairo folder to clean target

* Remove todo from execute method

* Separate helper functions from Cairo1HintProcessor implementation

* Add untracked file

* Fix

* Add changelog entry

* Add a job to compile cairo 1 contracts in ci

* Add job dependency

* Fix yml syntax

* Fix yml syntax

* Temporarily extempt cairo-1-hint-processor from codecov

* Fix yml syntax

* Fix workflow

* Remove cache code from new job

* Fix yml syntax

* Fix wrong path

* Fix makefile

* Build only compiler binaries

* Add cairo-1-contracts-cache

* Fetch contracts cache in jobs that need them

* Use no-std version of HashMap

* Import stdlib::prelude::*

* Wrap print in not-wasm block

* Remove std path

* use slices instead of vec

* Make DictSquashExecScope fields private

* Import hint processor dependencies without default features

* -Clippy

* Add type

* Compile cairo 1 contracts in build-programs job

* Rename cache

* Use target dependency instead of explicit $(MAKE)

* Fix yml syntax

* Check for cairo folder before cloning cairo repo

* Ommit folder name

* Swap paths

* Add cairo-1-hints feature flag

* Add compile-hint feature to tests run in workflow

* Add cairo-1-hints to test_utils

* Add cairo-1-hints to test_utils

* Use both paths when fetching compiled test data

* Remove cairo-1-hints feature from test_utils feature

* Move dependencies to cairo-1-hints feature

* Update CHANGELOG.md

* Fix cfg directive

* Add cairo-1-hints to test workflow

* Add Cairo 1 considerations for Gitignore and Makefile (lambdaclass#1144)

* Add ignore for casm and sierra files

* Add libfunc experimental for cairo 1 compilation

* Add new enty to CHANGELOG

* Add test for RandomEcPoint hint

* Add rust test for Cairo 1 program

* Fix Cairo 1 program

* Change contract & Add activate feature for Cairo 1

* Add new entry to Changelog

* Restore CHANGELOG.md

* Restore Cargo.toml

* Add eof new line

* Add more coverage to the test

* Refactor contract test

* Fix LinearSplit hint

* Add fix entry to the CHANGELOG

* Remove outdated comment

* Add test for FieldSqrt

* Remove CHANGELOG entry

* Fix Cairo 1 contract & test

* Add new line EOF Cairo 1 contract

---------

Co-authored-by: Federica <[email protected]>
Co-authored-by: fmoletta <[email protected]>
Co-authored-by: Pedro Fontana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmoletta fmoletta fmoletta approved these changes

@pefontana pefontana pefontana approved these changes

@igaray igaray Awaiting requested review from igaray igaray is a code owner

@Oppen Oppen Awaiting requested review from Oppen Oppen is a code owner

@entropidelic entropidelic Awaiting requested review from entropidelic

@juanbono juanbono Awaiting requested review from juanbono juanbono is a code owner

@Juan-M-V Juan-M-V Awaiting requested review from Juan-M-V

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make a Cairo 1 program for testing FieldSqrt hint
3 participants
@rcatalan98 @pefontana @fmoletta