Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add contribution guide #1152

Merged
merged 3 commits into from
May 11, 2023
Merged

ci: add contribution guide #1152

merged 3 commits into from
May 11, 2023

Conversation

Oppen
Copy link
Contributor

@Oppen Oppen commented May 10, 2023

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@Oppen Oppen added the pipelines This PR/issue is exclusively about improving our CI label May 10, 2023
@Oppen Oppen force-pushed the ci/conventional_commits_enforcement branch from b9661e9 to 552e16c Compare May 10, 2023 18:05
@Oppen Oppen marked this pull request as ready for review May 10, 2023 18:05
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #1152 (e69d7f2) into main (bd18580) will increase coverage by 1.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1152      +/-   ##
==========================================
+ Coverage   95.92%   97.36%   +1.43%     
==========================================
  Files          88       88              
  Lines       35539    35545       +6     
==========================================
+ Hits        34090    34607     +517     
+ Misses       1449      938     -511     

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Oppen Oppen force-pushed the ci/conventional_commits_enforcement branch from 552e16c to 423bfb4 Compare May 10, 2023 19:38
@Oppen Oppen changed the title ci: enforce conventional commit messages ci: add contribution guide May 10, 2023
Copy link
Contributor

@fmoletta fmoletta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

CONTRIBUTING.md Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented May 11, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 13.368 ± 0.270 13.124 14.077 1.00
head blake2s_integration_benchmark 13.534 ± 0.621 13.196 15.223 1.01 ± 0.05
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 4.065 ± 0.031 4.026 4.119 1.00
head compare_arrays_200000 4.139 ± 0.112 4.022 4.387 1.02 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.668 ± 0.022 2.647 2.721 1.00
head dict_integration_benchmark 2.669 ± 0.014 2.652 2.696 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 4.198 ± 0.021 4.163 4.231 1.00 ± 0.01
head factorial_multirun 4.197 ± 0.026 4.166 4.247 1.00
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 3.718 ± 0.029 3.669 3.757 1.01 ± 0.01
head fibonacci_1000_multirun 3.694 ± 0.019 3.662 3.719 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base field_arithmetic_get_square_benchmark 184.7 ± 1.6 182.9 187.5 1.00
head field_arithmetic_get_square_benchmark 185.7 ± 2.9 182.1 190.8 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 12.452 ± 0.571 12.079 14.049 1.02 ± 0.05
head integration_builtins 12.225 ± 0.149 12.054 12.475 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 13.790 ± 0.771 13.399 15.949 1.02 ± 0.06
head keccak_integration_benchmark 13.485 ± 0.238 13.216 13.991 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 4.080 ± 0.019 4.051 4.116 1.00
head linear_search 4.080 ± 0.032 4.032 4.130 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 2.848 ± 0.030 2.821 2.928 1.00
head math_cmp_and_pow_integration_benchmark 2.871 ± 0.045 2.834 2.985 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.701 ± 0.042 2.668 2.793 1.01 ± 0.02
head math_integration_benchmark 2.683 ± 0.020 2.660 2.719 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.271 ± 0.009 2.259 2.284 1.00 ± 0.01
head memory_integration_benchmark 2.269 ± 0.016 2.252 2.300 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.667 ± 0.013 2.650 2.687 1.00
head operations_with_data_structures_benchmarks 2.674 ± 0.018 2.654 2.720 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 908.3 ± 5.6 901.2 918.4 1.00
head pedersen 909.4 ± 8.7 903.0 933.4 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.616 ± 0.003 1.612 1.620 1.00
head poseidon_integration_benchmark 1.619 ± 0.004 1.612 1.625 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 3.188 ± 0.023 3.168 3.227 1.00 ± 0.01
head secp_integration_benchmark 3.184 ± 0.018 3.164 3.228 1.00
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.786 ± 0.005 1.778 1.796 1.00
head set_integration_benchmark 1.797 ± 0.030 1.775 1.869 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 8.268 ± 0.039 8.224 8.342 1.00
head uint256_integration_benchmark 8.310 ± 0.093 8.220 8.541 1.01 ± 0.01

@Oppen Oppen enabled auto-merge May 11, 2023 17:00
@Oppen Oppen added this pull request to the merge queue May 11, 2023
Merged via the queue into main with commit 7129b92 May 11, 2023
@Oppen Oppen deleted the ci/conventional_commits_enforcement branch May 11, 2023 18:07
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jun 23, 2023
* docs: CONTRIBUTING.md

* docs: fix issues links and refer to the new doc in readme

* docs: take two at links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipelines This PR/issue is exclusively about improving our CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants