Test divmod hint #1138

juanbono · 2023-05-08T03:02:06Z

Test divmod hint

Description

This PR adds a test for the divmod (Cairo 10) hint.

Checklist

Linked to Github Issue
Unit tests added
Integration tests added.
This change requires new documentation.
- Documentation has been added/updated.
- CHANGELOG has been updated.

…o-rs into run-casm-contract-class

* Add ignore for casm and sierra files * Add libfunc experimental for cairo 1 compilation * Add new enty to CHANGELOG

github-actions · 2023-05-08T19:25:10Z

Benchmark Results for unmodified programs 🚀

Command	Mean [s]	Min [s]	Max [s]	Relative
`base blake2s_integration_benchmark`	13.382 ± 0.207	13.114	13.701	1.01 ± 0.02
`head blake2s_integration_benchmark`	13.306 ± 0.092	13.202	13.474	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base compare_arrays_200000`	4.054 ± 0.031	4.017	4.114	1.00
`head compare_arrays_200000`	4.070 ± 0.034	4.031	4.143	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
`base dict_integration_benchmark`	2.689 ± 0.016	2.668	2.717	1.00 ± 0.01
`head dict_integration_benchmark`	2.680 ± 0.012	2.665	2.702	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base factorial_multirun`	4.210 ± 0.052	4.172	4.322	1.00
`head factorial_multirun`	4.220 ± 0.045	4.173	4.303	1.00 ± 0.02

Command	Mean [s]	Min [s]	Max [s]	Relative
`base fibonacci_1000_multirun`	3.698 ± 0.018	3.675	3.725	1.00
`head fibonacci_1000_multirun`	3.705 ± 0.038	3.660	3.788	1.00 ± 0.01

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`base field_arithmetic_get_square_benchmark`	183.2 ± 1.7	180.1	185.8	1.00
`head field_arithmetic_get_square_benchmark`	183.5 ± 1.8	180.6	187.4	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
`base integration_builtins`	12.408 ± 0.576	12.057	13.977	1.01 ± 0.05
`head integration_builtins`	12.237 ± 0.190	12.038	12.531	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base keccak_integration_benchmark`	13.687 ± 0.396	13.354	14.694	1.01 ± 0.04
`head keccak_integration_benchmark`	13.494 ± 0.296	13.312	14.316	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base linear_search`	4.089 ± 0.027	4.053	4.140	1.00
`head linear_search`	4.090 ± 0.023	4.059	4.134	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
`base math_cmp_and_pow_integration_benchmark`	2.876 ± 0.014	2.860	2.901	1.00
`head math_cmp_and_pow_integration_benchmark`	2.885 ± 0.048	2.855	3.018	1.00 ± 0.02

Command	Mean [s]	Min [s]	Max [s]	Relative
`base math_integration_benchmark`	2.686 ± 0.010	2.675	2.698	1.00
`head math_integration_benchmark`	2.727 ± 0.054	2.675	2.839	1.02 ± 0.02

Command	Mean [s]	Min [s]	Max [s]	Relative
`base memory_integration_benchmark`	2.303 ± 0.017	2.281	2.334	1.00
`head memory_integration_benchmark`	2.315 ± 0.044	2.274	2.397	1.01 ± 0.02

Command	Mean [s]	Min [s]	Max [s]	Relative
`base operations_with_data_structures_benchmarks`	2.682 ± 0.024	2.664	2.746	1.00 ± 0.01
`head operations_with_data_structures_benchmarks`	2.676 ± 0.006	2.669	2.685	1.00

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`base pedersen`	912.8 ± 3.6	907.4	919.7	1.00 ± 0.01
`head pedersen`	912.2 ± 3.2	905.9	915.6	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base poseidon_integration_benchmark`	1.637 ± 0.005	1.630	1.646	1.00 ± 0.00
`head poseidon_integration_benchmark`	1.634 ± 0.006	1.623	1.641	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base secp_integration_benchmark`	3.196 ± 0.017	3.175	3.227	1.00
`head secp_integration_benchmark`	3.205 ± 0.037	3.172	3.285	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
`base set_integration_benchmark`	1.806 ± 0.014	1.796	1.842	1.00 ± 0.01
`head set_integration_benchmark`	1.805 ± 0.020	1.787	1.851	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base uint256_integration_benchmark`	8.337 ± 0.123	8.266	8.680	1.00 ± 0.02
`head uint256_integration_benchmark`	8.319 ± 0.035	8.281	8.381	1.00

igamigo

LGTM!

codecov · 2023-05-08T22:27:26Z

Codecov Report

Merging #1138 (b3cc5e7) into main (a789eee) will increase coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1138      +/-   ##
==========================================
+ Coverage   96.41%   96.52%   +0.10%     
==========================================
  Files          88       88              
  Lines       35319    35319              
==========================================
+ Hits        34053    34090      +37     
+ Misses       1266     1229      -37

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

* Implement TryFrom<CasmContractClass> for Program * Add cairo1hintprocessor dependency * Map hints to pc * Add Cairo1HintProcessor * Move cairo-1-hint-processor to cairo-rs crate * fixes * Fix test helper * Remove allow * fix test func * Add builtins to test * Extract builtins from contract_class * Add _builtin to builtin names in etrypoint data * Copy logic from cairo1 contract execution in starknet * Remove unused code * Use lower initial_gas value * Add program segment size argument * Check return values in run_cairo_1_entrypoint fn * Remove debug prints * Add basic fibonacci test * Add another fibonacci case * Always verify secure * Clippy * Compile casm contracts when running test target * Remove unwrap from cell_ref_to_relocatable * Remove paniking macro from extract_buffer * Misc improvements * Misc improvements * Misc improvements * Misc improvements * Remove unwraps & asserts from DictSquashExecScope::pop_current_key * Remove unwraps & asserts from DictManagerExecScope::new_default_dict * Remove expect from get_dict_tracker * Add constants for cairo 1 compiler binaries in makefile * Add cairo 1 compiler to deps target in makefile * Add cairo folder to clean target * Remove todo from execute method * Separate helper functions from Cairo1HintProcessor implementation * Add untracked file * Fix * Add changelog entry * Add a job to compile cairo 1 contracts in ci * Add job dependency * Fix yml syntax * Fix yml syntax * Temporarily extempt cairo-1-hint-processor from codecov * Fix yml syntax * Fix workflow * Remove cache code from new job * Fix yml syntax * Fix wrong path * Fix makefile * Build only compiler binaries * Add cairo-1-contracts-cache * Fetch contracts cache in jobs that need them * Use no-std version of HashMap * Import stdlib::prelude::* * Wrap print in not-wasm block * Remove std path * use slices instead of vec * Make DictSquashExecScope fields private * Import hint processor dependencies without default features * -Clippy * Add type * Compile cairo 1 contracts in build-programs job * Rename cache * Use target dependency instead of explicit $(MAKE) * Fix yml syntax * Check for cairo folder before cloning cairo repo * Ommit folder name * Swap paths * Add cairo-1-hints feature flag * Add compile-hint feature to tests run in workflow * Add cairo-1-hints to test_utils * Add cairo-1-hints to test_utils * Use both paths when fetching compiled test data * Remove cairo-1-hints feature from test_utils feature * Move dependencies to cairo-1-hints feature * add test * Update CHANGELOG.md * Fix cfg directive * Add cairo-1-hints to test workflow * Add Cairo 1 considerations for Gitignore and Makefile (lambdaclass#1144) * Add ignore for casm and sierra files * Add libfunc experimental for cairo 1 compilation * Add new enty to CHANGELOG * update CHANGELOG.md * cargo fmt --------- Co-authored-by: Federica <[email protected]> Co-authored-by: fmoletta <[email protected]> Co-authored-by: Roberto Catalan <[email protected]> Co-authored-by: Pedro Fontana <[email protected]>

fmoletta added 30 commits April 28, 2023 12:35

Implement TryFrom<CasmContractClass> for Program

ad090c0

Add cairo1hintprocessor dependency

814f62f

Map hints to pc

5ad52b3

Add Cairo1HintProcessor

2c80935

Move cairo-1-hint-processor to cairo-rs crate

31833c0

fixes

a0974fc

Fix test helper

3257b9d

Remove allow

6eb32a6

fix test func

95be386

Add builtins to test

0ce7380

Extract builtins from contract_class

ee4db2c

Add _builtin to builtin names in etrypoint data

f0d4151

Copy logic from cairo1 contract execution in starknet

4032a94

Remove unused code

6c9be63

Use lower initial_gas value

52984d7

Add program segment size argument

151375f

Check return values in run_cairo_1_entrypoint fn

f11e350

Remove debug prints

f466aa7

Add basic fibonacci test

8a528a0

Add another fibonacci case

c4fbe31

Always verify secure

5debb70

Clippy

4d614a8

Compile casm contracts when running test target

df1bf8f

Remove unwrap from cell_ref_to_relocatable

59b6381

Remove paniking macro from extract_buffer

2649829

Misc improvements

ecb58d6

Misc improvements

2d9362d

Misc improvements

38be92c

Misc improvements

a82308b

Remove unwraps & asserts from DictSquashExecScope::pop_current_key

8d6c5cb

juanbono marked this pull request as ready for review May 8, 2023 12:22

juanbono requested review from igaray, Oppen, fmoletta, entropidelic, pefontana and Juan-M-V as code owners May 8, 2023 12:22

juanbono changed the base branch from main to run-casm-contract-class May 8, 2023 12:23

juanbono linked an issue May 8, 2023 that may be closed by this pull request

Make a program for testing DivMod hint #1101

Closed

fmoletta added 2 commits May 8, 2023 16:29

Merge branch 'main' into run-casm-contract-class

8714bfb

Update CHANGELOG.md

f0dcbb6

fmoletta approved these changes May 8, 2023

View reviewed changes

fmoletta and others added 6 commits May 8, 2023 11:53

Fix cfg directive

f4f97e9

Merge branch 'run-casm-contract-class' of github.com:lambdaclass/cair…

513bca1

…o-rs into run-casm-contract-class

Add cairo-1-hints to test workflow

8de5453

Add Cairo 1 considerations for Gitignore and Makefile (#1144)

d1c9dda

* Add ignore for casm and sierra files * Add libfunc experimental for cairo 1 compilation * Add new enty to CHANGELOG

update CHANGELOG.md

a1b5f27

Merge branch 'run-casm-contract-class' into test_divmod_hint

2c9c94f

Base automatically changed from run-casm-contract-class to main May 8, 2023 21:57

Merge branch 'main' into test_divmod_hint

7a86913

igamigo approved these changes May 8, 2023

View reviewed changes

pefontana enabled auto-merge May 8, 2023 22:15

cargo fmt

b3cc5e7

pefontana added this pull request to the merge queue May 8, 2023

Merged via the queue into main with commit 70f3b1e May 8, 2023

pefontana deleted the test_divmod_hint branch May 8, 2023 23:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test divmod hint #1138

Test divmod hint #1138

juanbono commented May 8, 2023 •

edited

Loading

github-actions bot commented May 8, 2023 •

edited

Loading

igamigo left a comment

codecov bot commented May 8, 2023 •

edited

Loading

Test divmod hint #1138

Test divmod hint #1138

Conversation

juanbono commented May 8, 2023 • edited Loading

Test divmod hint

Description

Checklist

github-actions bot commented May 8, 2023 • edited Loading

igamigo left a comment

Choose a reason for hiding this comment

codecov bot commented May 8, 2023 • edited Loading

Codecov Report

juanbono commented May 8, 2023 •

edited

Loading

github-actions bot commented May 8, 2023 •

edited

Loading

codecov bot commented May 8, 2023 •

edited

Loading