-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hints): "full word" from cairo_keccak.json #1058
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oppen
requested review from
igaray,
fmoletta,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
April 26, 2023 05:17
Benchmark Results for unmodified programs 🚀
|
Codecov Report
@@ Coverage Diff @@
## main #1058 +/- ##
=======================================
Coverage 98.10% 98.10%
=======================================
Files 84 84
Lines 33994 34008 +14
=======================================
+ Hits 33349 33363 +14
Misses 645 645
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Oppen
force-pushed
the
feat(hint)/68-sha512_input
branch
3 times, most recently
from
April 26, 2023 09:49
fee8cdf
to
caf069e
Compare
Oppen
force-pushed
the
feat(hint)/68-sha512_input
branch
from
April 26, 2023 09:58
caf069e
to
7b151ef
Compare
fmoletta
approved these changes
Apr 26, 2023
MegaRedHand
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last remaining hint from whitelist
cairo_keccak.json
. The branch's name comes from its similarity to that ofSHA256_INPUT
. It turns out it's used for_copy_input
instead, so it's misleading.The hint:
Fixes #1020
Checklist