-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newhint#20 and Newhint#16: add COMPUTE_SLOPE_SECP256R1 and IMPORT_SECP256R1_P #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfachal
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
April 19, 2023 18:15
Benchmark Results for unmodified programs 🚀
|
Codecov Report
@@ Coverage Diff @@
## main #1014 +/- ##
=======================================
Coverage 98.07% 98.08%
=======================================
Files 78 78
Lines 32541 32572 +31
=======================================
+ Hits 31916 31947 +31
Misses 625 625
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Oppen
approved these changes
Apr 19, 2023
Oppen
reviewed
Apr 19, 2023
MegaRedHand
reviewed
Apr 20, 2023
pefontana
added
the
whitelisted-hint
Implementation of hint on whitelist directory
label
Apr 20, 2023
MegaRedHand
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Apr 26, 2023
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
…P256R1_P (lambdaclass#1014) * add newhint#20 * add slope_compute program * format * fix hint#16 string * WIP * WIP add SECP_P to exec_scopes * WIP add SECP_P to exec_scope * add newhint#16 and newhint#20 * update changelog * use BigUint for SECP256R1_N and SECP256R1_ALPHA * refactor compute_slope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TITLE
Description
Add
COMPUTE_SLOPE_SECP256R1
andIMPORT_SECP256R1_P
hints (NewHint#20 and NewHint#16)Checklist