Add _builtin suffix to builtin names.

[alonh5]

TITLE

Description

Description of the pull request changes and motivation.

Checklist

• Linked to Github Issue
• Unit tests added
• Integration tests added.
• This change requires new documentation.
  • Documentation has been added/updated.
  • CHANGELOG has been updated.

[github-actions]

Benchmark Results for unmodified programs 🚀

Command	Mean [s]	Min [s]	Max [s]	Relative
base blake2s_integration_benchmark	3.011 ± 0.045	2.968	3.119	1.00
head blake2s_integration_benchmark	3.016 ± 0.026	2.980	3.063	1.00 ± 0.02

Command	Mean [s]	Min [s]	Max [s]	Relative
base compare_arrays_200000	3.624 ± 0.027	3.590	3.693	1.00
head compare_arrays_200000	3.638 ± 0.033	3.603	3.707	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base dict_integration_benchmark	2.744 ± 0.040	2.709	2.854	1.01 ± 0.02
head dict_integration_benchmark	2.728 ± 0.012	2.709	2.749	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base factorial_multirun	4.443 ± 0.032	4.411	4.507	1.00 ± 0.01
head factorial_multirun	4.439 ± 0.025	4.411	4.489	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base fibonacci_1000_multirun	3.553 ± 0.017	3.533	3.595	1.00
head fibonacci_1000_multirun	3.580 ± 0.020	3.550	3.614	1.01 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base integration_builtins	3.571 ± 0.028	3.532	3.617	1.00
head integration_builtins	3.586 ± 0.037	3.550	3.649	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base keccak_integration_benchmark	3.296 ± 0.019	3.273	3.337	1.00
head keccak_integration_benchmark	3.329 ± 0.031	3.299	3.410	1.01 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base linear_search	3.801 ± 0.023	3.764	3.832	1.00
head linear_search	3.825 ± 0.024	3.783	3.860	1.01 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base math_cmp_and_pow_integration_benchmark	3.169 ± 0.061	3.117	3.317	1.00 ± 0.02
head math_cmp_and_pow_integration_benchmark	3.167 ± 0.030	3.138	3.241	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base math_integration_benchmark	2.843 ± 0.022	2.823	2.881	1.00
head math_integration_benchmark	2.847 ± 0.016	2.831	2.881	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base memory_integration_benchmark	2.500 ± 0.024	2.468	2.558	1.00
head memory_integration_benchmark	2.528 ± 0.014	2.509	2.550	1.01 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base operations_with_data_structures_benchmarks	2.500 ± 0.012	2.484	2.519	1.00
head operations_with_data_structures_benchmarks	2.528 ± 0.043	2.485	2.613	1.01 ± 0.02

Command	Mean [s]	Min [s]	Max [s]	Relative
base pedersen	3.390 ± 0.012	3.377	3.415	1.00 ± 0.00
head pedersen	3.380 ± 0.008	3.367	3.390	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base poseidon_integration_benchmark	1.554 ± 0.006	1.544	1.566	1.00
head poseidon_integration_benchmark	1.556 ± 0.006	1.548	1.566	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base secp_integration_benchmark	2.771 ± 0.023	2.747	2.817	1.00
head secp_integration_benchmark	2.779 ± 0.021	2.761	2.833	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base set_integration_benchmark	1.989 ± 0.008	1.977	2.001	1.10 ± 0.01
head set_integration_benchmark	1.811 ± 0.011	1.791	1.830	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base uint256_integration_benchmark	4.354 ± 0.038	4.332	4.459	1.00
head uint256_integration_benchmark	4.359 ± 0.012	4.344	4.380	1.00 ± 0.01

[codecov]

Codecov Report

Merging #1005 (4307125) into main (39cea94) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1005   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files          76       76           
  Lines       31621    31621           
=======================================
  Hits        30997    30997           
  Misses        624      624           

Impacted Files	Coverage Δ
src/vm/runners/builtin_runner/mod.rs	99.28% <ø> (ø)
src/vm/runners/cairo_runner.rs	98.07% <100.00%> (ø)
src/vm/vm_core.rs	97.86% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[Oppen]

It should mention it's (technically) a breaking change. Any code not expecting the suffix would break.

[pefontana]

Done!
4307125

[Oppen]

Minor change to the CHANGELOG needed.
Also, I know it's not documented or enforced anywhere (yet), but we're planning on using conventional commits so updating the CHANGELOG could be automated or at least assisted by the CI, so I would appreciate if we could start following those.

[pefontana]

Minor change to the CHANGELOG needed. Also, I know it's not documented or enforced anywhere (yet), but we're planning on using conventional commits so updating the CHANGELOG could be automated or at least assisted by the CI, so I would appreciate if we could start following those.

Thanks for the remainder @Oppen !
Didn't get used to it yet

[Oppen]

Thanks for the remainder @Oppen !
Didn't get used to it yet

No worries. Do note it's not a blocker. Just if you need to change something else, seize the opportunity. Until documented/enforced by CI I won't consider such thing a must because it would be unfair to reject PRs based on something we didn't tell was needed :)