Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support axum v0.7 through axum-core v0.4 and http v1 #401

Merged
merged 9 commits into from
Dec 30, 2023
Merged

Support axum v0.7 through axum-core v0.4 and http v1 #401

merged 9 commits into from
Dec 30, 2023

Conversation

vidhanio
Copy link
Contributor

@vidhanio vidhanio commented Nov 27, 2023 •
edited
Loading

closes #402

@vidhanio
Copy link
Contributor Author

8th time's the charm i guess, LOL

@vidhanio vidhanio changed the title chore: bump axum-core for use with new axum 0.7 release chore: bump axum to 0.7, axum-core to 0.4, http to 1 Nov 27, 2023
This was referenced Nov 28, 2023
Merged
Closed
@vidhanio vidhanio changed the title chore: bump axum to 0.7, axum-core to 0.4, http to 1 Support axum v0.7 through axum-core v0.4 and http v1 Nov 30, 2023
@philipcristiano
Copy link

@lambda-fairy are you able to take a look?

@evgenykobz
Copy link

Apparently, this breaking change broke the latest v. of Maud:

breaking: The response returned by IntoResponse::into_response must use axum::body::Body as the body type. axum::response::Response does this.

@vidhanio
Copy link
Contributor Author

vidhanio commented Dec 7, 2023

Apparently, this breaking change broke the latest v. of Maud:

breaking: The response returned by IntoResponse::into_response must use axum::body::Body as the body type. axum::response::Response does this.

not just that. it's a semver-incompatible version bump which means the types are no longer compatible across projects with axum 0.6 as their dep vs axum 0.7.

@10ne1
Copy link

10ne1 commented Dec 28, 2023

Gentle ping - it would be awesome if this could land. Thanks!

@jryio
Copy link

jryio commented Dec 28, 2023

Likewise. I am currently pulling the forked branch into my project(s) to use with axum 0.7 (everything is working correctly so far) - thanks!

@lambda-fairy lambda-fairy merged commit d3b8711 into lambda-fairy:main Dec 30, 2023
4 checks passed
@lambda-fairy
Copy link
Owner

Thanks for the patience!

@vidhanio vidhanio deleted the patch-1 branch December 31, 2023 03:29
philipcristiano added a commit to philipcristiano/hello_idc that referenced this pull request Jan 4, 2024
@philipcristiano
chore: axum 0.7 / maud >0.25 compat
c2d8705 
Maud has compatability for 0.7 with
lambda-fairy/maud#401 but it isn't released in a
0.26 version yet.

Use a source release with specific rev until a 0.26 is cut
@philipcristiano
Copy link

@lambda-fairy any chance you could release a new version to crates.io now that this has been merged?

philipcristiano added a commit to philipcristiano/hello_idc that referenced this pull request Jan 4, 2024
@philipcristiano
chore: axum 0.7 / maud >0.25 compat
0ef9cb7 
Maud has compatability for 0.7 with
lambda-fairy/maud#401 but it isn't released in a
0.26 version yet.

Use a source release with specific rev until a 0.26 is cut
@lambda-fairy
Copy link
Owner

@philipcristiano I'll likely get to it this weekend. In the meantime, using a git dependency (like you've done) is good and supported.

I've been thinking about the literals-in-attribute-names proposal (#396 + #398). I don't feel comfortable releasing that in its current state. I want to collect my thoughts and decide whether to revert or polish that up first.

@jryio
Copy link

jryio commented Jan 8, 2024

Grateful for your work on this crate @lambda-fairy! Thank you!

@lambda-fairy
Copy link
Owner

https://crates.io/crates/maud/0.26.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump axum-core to 0.4
6 participants
@vidhanio @philipcristiano @evgenykobz @10ne1 @jryio @lambda-fairy