actix-web >= 2.0.0 support #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support both actix-web < 2.0.0 and >= 2.0.0 at the same time I added a feature actix-web-2, which enables the actix-web dependency with the respective version und the name active-web-2-dep and the futures dependency which is required(?) for implementing the Responder trait for >= 2.0.0. Thus the user of maud has the choice to use actix-web in the version they prefer.
|
Thanks for your contribution! How about we drop 1.x support and only support 2.x? Users who are still using actix-web 1.x can pin to an older version of Maud, so I don't think we need to support both at once. |
|
Sure, I'll modify the PR accordingly! |
|
I removed the 1.0.0 support and added only the 2.0.0 support. I reverted the changes to the documentation as well, since they are no longer necessary. I also took the liberty to modify the changelog accordingly. |
|
Merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cheers,
With the advent of async, actix-web started using futures in their APIs and traits, unfortunately resulting in breaking changes within the Responder trait which maud implements.
I have added support for the newest version of actix-web while trying to still support version 1, since most users have probably not yet migrated to the newest version.
In order to do so I added the trait
actix-web-2feature and theactix-web-2-depdependency in order to avoid name clashes. Unfortunately enabling the feature also depends on thefuturescrate, since it is used to implement the Responder trait. I also mentioned said support in the web-framework documentation. I have not added any tests, since there were no actix-web tests I could modify. I have verified that this change works within my own project though.Note that
futuresdependency may not necessarily be required. It was used within actix-web itself to implement the Responder traits, but I could not trivially verify that it is strictly required to use that crate and not some other implementation.P.S. Thanks for your awesome crate!