Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implicit div class/id shorthand #172 #173

Merged
merged 3 commits into from
Apr 20, 2019
Merged

Add implicit div class/id shorthand #172 #173

merged 3 commits into from
Apr 20, 2019

Conversation

yhtez
Copy link
Contributor

@yhtez yhtez commented Apr 7, 2019

No description provided.

@yhtez yhtez changed the title Add implicit div class/id shorthand (#172) Add implicit div class/id shorthand #172 Apr 7, 2019
Copy link
Owner

@lambda-fairy lambda-fairy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me 🙂

Would you like to write the documentation for this as well? No worries if you don't want to.

maud/tests/basic_syntax.rs Outdated Show resolved Hide resolved
@yhtez
Copy link
Contributor Author

yhtez commented Apr 15, 2019

I fixed the newline and added a bit of basic documentation, could maybe do with better wording but I'll leave it up to you whether it is fine as is.

Copy link
Owner

@lambda-fairy lambda-fairy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@lambda-fairy lambda-fairy merged commit f3a4c29 into lambda-fairy:master Apr 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants