Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump iron to 0.6.0 version #107

Merged
merged 1 commit into from
Nov 12, 2017
Merged

Bump iron to 0.6.0 version #107

merged 1 commit into from
Nov 12, 2017

Conversation

ernestas-poskus
Copy link
Contributor

No description provided.

@sanmai-NL
Copy link
Contributor

Woops! You beat me to it. I'll close #108.

@sanmai-NL sanmai-NL mentioned this pull request Nov 7, 2017
Closed
lambda-fairy
lambda-fairy requested changes Nov 8, 2017
View reviewed changes
Copy link
Owner

@lambda-fairy lambda-fairy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the library still works with Iron 0.5.1, can you make this depend on the full range >= 0.5.1, < 0.7.0 instead?

This also needs an entry in the change log.

@ernestas-poskus ernestas-poskus force-pushed the features/bump_iron_to_0_6_0 branch from f141b57 to 3cebd71 Compare November 8, 2017 08:19
@ernestas-poskus
Copy link
Contributor Author

ernestas-poskus commented Nov 8, 2017 •
edited
Loading

updated, should I adjust commit message to Bump iron to 0.6.0 version to specified version range ?

@lambda-fairy lambda-fairy merged commit 250c736 into lambda-fairy:master Nov 12, 2017
@lambda-fairy
Copy link
Owner

lambda-fairy commented Nov 12, 2017 •
edited
Loading

Thanks! I think the commit message is okay.

(The change log entry should have a link to the PR as well, but I'll go ahead and add it myself.)

lambda-fairy added a commit that referenced this pull request Nov 12, 2017
@lambda-fairy
Tweak change log entry for #107
fd43d6c
@ernestas-poskus ernestas-poskus deleted the features/bump_iron_to_0_6_0 branch November 12, 2017 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambda-fairy lambda-fairy lambda-fairy requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ernestas-poskus @sanmai-NL @lambda-fairy