-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
escape.rs symlink broken on Windows #343
Comments
Oh, that's unfortunate. I originally added that symlink to avoid duplicating the file. I thought it was an improvement over the previous approach, which was to publish a separate helper crate that was a dependency of both. What do other libraries do instead? |
Could we just have |
IIRC, proc macro crates can only export macros, not normal functions. |
This is broken on NixOS too when building in the nix store. |
Looks like the symlink approach has too many downsides. I'll just duplicate it then 😿 |
The symlink doesn't work on Windows, and breaks NixOS builds. Closes #343
The symlink doesn't work on Windows, and breaks NixOS builds. Closes #343
Current main is broken on Windows due to maud_macros/src/escape.rs being a symlink, which is broken on Windows.
The obvious fix would be to copy-and-paste the contents over, but perhaps there's a better solution?
The text was updated successfully, but these errors were encountered: