Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escape.rs symlink broken on Windows #343

Closed
lunabunn opened this issue May 12, 2022 · 5 comments · Fixed by #355
Closed

escape.rs symlink broken on Windows #343

lunabunn opened this issue May 12, 2022 · 5 comments · Fixed by #355
Labels

Comments

@lunabunn
Copy link

lunabunn commented May 12, 2022

Current main is broken on Windows due to maud_macros/src/escape.rs being a symlink, which is broken on Windows.

The obvious fix would be to copy-and-paste the contents over, but perhaps there's a better solution?

@lambda-fairy
Copy link
Owner

Oh, that's unfortunate.

I originally added that symlink to avoid duplicating the file. I thought it was an improvement over the previous approach, which was to publish a separate helper crate that was a dependency of both.

What do other libraries do instead?

@lunabunn
Copy link
Author

lunabunn commented May 24, 2022

Oh, that's unfortunate.

I originally added that symlink to avoid duplicating the file. I thought it was an improvement over the previous approach, which was to publish a separate helper crate that was a dependency of both.

What do other libraries do instead?

Could we just have escape.rs live in maud_macros as a pub mod (or be reexported), and then use that from maud?

@lambda-fairy
Copy link
Owner

IIRC, proc macro crates can only export macros, not normal functions.

@Xe
Copy link

Xe commented Jul 10, 2022

This is broken on NixOS too when building in the nix store.

@lambda-fairy
Copy link
Owner

Looks like the symlink approach has too many downsides. I'll just duplicate it then 😿

lambda-fairy added a commit that referenced this issue Sep 18, 2022
The symlink doesn't work on Windows, and breaks NixOS builds.

Closes #343
lambda-fairy added a commit that referenced this issue Sep 18, 2022
The symlink doesn't work on Windows, and breaks NixOS builds.

Closes #343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants