Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axum integration does not work with v0.5 #339

Closed
jquesada2016 opened this issue Apr 29, 2022 · 5 comments
Closed

Axum integration does not work with v0.5 #339

jquesada2016 opened this issue Apr 29, 2022 · 5 comments

Comments

@jquesada2016
Copy link

jquesada2016 commented Apr 29, 2022

The current version of maud does not work with the latest version of axum.

This appears to be a version incompatibility.

@jquesada2016
Copy link
Author

I was taking a look at this to create a pull request to fix it, but it seems like there's something else going on. The compiler is saying that the IntoResponse trait implemented by maud is different (axum-core) than the one used by axum directly, which doesn't make any sense. I'll report back as soon as I find something.

@lambda-fairy
Copy link
Owner

Hi @jquesada2016, thanks for reporting. #337 added Axum 0.5 support, but it's not released yet. You can either use a git dependency or wait for me to cut a release. Sorry for the confusion!

@jquesada2016
Copy link
Author

Hello! You beat me to it! I was especially confused because the version in Cargo.toml on the main branch was 0.23, which I was using, but when checking the sources, they didn't match at all! It wasn't until I tried linking directly to the git dependency that it worked. Good to move to use axum-core, which is pretty stable, vs axum directly.

@lambda-fairy
Copy link
Owner

No worries – thank the Axum maintainers for doing that 🙂

@yudai-nkt
Copy link

Hi @lambda-fairy. Thanks for making maud, I really like your compile-time approach!

You can either use a git dependency or wait for me to cut a release.

Would you mind releasing a new version that includes this fix? I was fine with the git dependency until recently, but when it comes to publishing my binary crate to crates.io, the registry won't allow git dependency and causes me this error saying "all dependencies must have a version specified when publishing."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants