Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide on a merged import style #281

Closed
lambda-fairy opened this issue Aug 2, 2021 · 1 comment · Fixed by #290
Closed

Decide on a merged import style #281

lambda-fairy opened this issue Aug 2, 2021 · 1 comment · Fixed by #290
Labels
cleanup needs feedback

Comments

@lambda-fairy
Copy link
Owner

See https://rust-lang.github.io/rustfmt/#imports_granularity

Currently, Maud uses the "module" style. But we should consider switching to "crate" style instead.
@lambda-fairy lambda-fairy mentioned this issue Aug 4, 2021
Merged
@lambda-fairy
Copy link
Owner Author

Only disadvantage I can see is that imports_granularity is still unstable (rust-lang/rustfmt#4681). So we'll need everyone who contributes to Maud to use nightly.

I don't think that's an issue, though, since the tests are already nightly-only.

lambda-fairy added a commit that referenced this issue Sep 11, 2021
@lambda-fairy
Enforce merged imports
09c9934 
Closes #281
@lambda-fairy lambda-fairy mentioned this issue Sep 11, 2021
Merged
lambda-fairy added a commit that referenced this issue Sep 11, 2021
@lambda-fairy
Enforce merged imports (#290)
dc02811 
Closes #281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup needs feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enforce merged imports lambda-fairy/maud
1 participant
@lambda-fairy